[Sync] Correct inter-core sync lowering semantics for A3/A5#258
Open
TaoTao-real wants to merge 1 commit intozhangstevenunity:mainfrom
Open
[Sync] Correct inter-core sync lowering semantics for A3/A5#258TaoTao-real wants to merge 1 commit intozhangstevenunity:mainfrom
TaoTao-real wants to merge 1 commit intozhangstevenunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR only contains inter-core sync support changes:
pto.sync.set/pto.sync.waitsync.set -> ffts_cross_core_sync(pipe, getFFTSMsg(FFTS_MODE_VAL, event_id))sync.wait -> wait_flag_dev(event_id)sync.set -> set_intra_block(pipe, event_id)sync.wait -> wait_intra_block(pipe, event_id)PTOToEmitCpto.set_fftsEmitC lowering toset_ffts_base_addr(...)pto.set_fftsin the same function now failssync_set,sync_wait,set_fftstest_intercore_sync_a3.pytest_intercore_sync_a5.pytest_intercore_sync_a3_missing_setffts.pyrunop.shwith arch-aware routing + structural assertions for the new samplesScope guard
Diff vs
maincontains only 6 files:lib/PTO/Transforms/PTOToEmitC.cpppython/pto/dialects/pto.pytest/samples/runop.shtest/samples/Sync/test_intercore_sync_a3.pytest/samples/Sync/test_intercore_sync_a5.pytest/samples/Sync/test_intercore_sync_a3_missing_setffts.pyValidation
Local validation passed:
ninja -C build ptoas installbash test/samples/runop.sh -t Sync(A3 default)PTOAS_FLAGS='--pto-arch=a5 --enable-insert-sync' bash test/samples/runop.sh -t SyncBoth A3/A5 new regression assertions are hit as expected, and the A3 missing-
set_fftscase is XFAIL with the expected diagnostic.