fix(pto): infer matmul tile config by target arch#260
Draft
HecreReed wants to merge 2 commits intozhangstevenunity:mainfrom
Draft
fix(pto): infer matmul tile config by target arch#260HecreReed wants to merge 2 commits intozhangstevenunity:mainfrom
HecreReed wants to merge 2 commits intozhangstevenunity:mainfrom
Conversation
9481541 to
01f8be4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pto-infer-tile-configpass that derives LEFT/RIGHT/ACC tile config frompto.target_archPTOViewToMemrefso emittedpointer_cast/bind_tilemetadata matches the target ISA on both A3 and A5.ptoinputs that lock the generatedTile<...>templates for matmul operands/resultsWhy
BLayout/SLayoutinto matmul tilesTesting
ninja -C build-llvm19 ptoasbuild-llvm19/tools/ptoas/ptoas --pto-arch=a3 test/basic/matmul_tile_config_infer_a3.pto | /opt/homebrew/opt/llvm@19/bin/FileCheck test/basic/matmul_tile_config_infer_a3.ptobuild-llvm19/tools/ptoas/ptoas --pto-arch=a5 test/basic/matmul_tile_config_infer_a5.pto | /opt/homebrew/opt/llvm@19/bin/FileCheck test/basic/matmul_tile_config_infer_a5.pto