fix: fix bug in worker example, so that the last second of audio would be fully encoded#96
Open
malvill wants to merge 1 commit into
Open
fix: fix bug in worker example, so that the last second of audio would be fully encoded#96malvill wants to merge 1 commit into
malvill wants to merge 1 commit into
Conversation
…d be fully encoded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last second (or less) of audio were not encoded into mp3.
When the "remaining" becomes less than the "maxSamples" constant, we exit the loop for encoding audio portions. However, "remaining" may be non-zero, so part of the audio at the end will remain not encoded.