Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the Maven Wrapper to the project, which bootstraps a Maven environment. The Maven Wrapper is a best practice, and will be included in Maven 3.7.0 by default.
I created the files in this PR by running the following command against the repo:
It works by running
./mvnwor./mvnw.cmdinstead of themvncommand. In this way, it ensures that all users are running the same version of Maven. You can read more about it on the Baeldung blog.Accepting this change would make it significantly easier to build the plugin in an automated environment.
For context, I'm trying to add RaspberryJuice support to the Minecraft Buildpack, which must build the plugin from source (alternatively, it could download a pre-compiled version of the plugin, but I didn't know where to find one).