fix(release): ship Windows as x86_64 only, as 0.4.1 - #33
Merged
Merged
Conversation
The aarch64 Windows build of 0.4.0 crashed at startup on a Windows ARM runner, before printing its version, so the release check stopped it and the release stayed an unpublished draft. The x86_64 build passed the same check on Windows, and Windows on ARM runs it under the system's x86_64 emulation. The release now builds, checks and expects only that Windows zip, ten assets in all, and the notes and README say so. The ARM crash is tracked on its own.
It took the newest tag, and a tag whose release is still a draft has no downloads, so the check failed on the 0.4.0 draft before it had anything to do with the change under test. It now asks GitHub for the newest release that is published.
The same newest-tag read sat in the check that a download which does not verify is refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aarch64 Windows build of 0.4.0 crashed at startup on the windows-11-arm runner (a segfault before
deed versionprinted anything), so the release check stopped it and 0.4.0 stayed an unpublished draft. The x86_64 zip passed the same check on windows-latest, and Windows on ARM runs it under the system's x86_64 emulation.This drops the aarch64 Windows zip from the release build, its run check and the asset lists (ten assets now), updates the README and release notes to match, and moves the version to 0.4.1 so the release is cut again. Nothing else changes from #32.