The dial cancellation test cannot hang on a slow runner - #115
Merged
Merged
Conversation
…w the cancel std.testing.allocator captures a stack trace on every allocation, and on macOS that takes a lock which swallows a pending cancel. A dial cancelled while still allocating would then never return, and the test would hang instead of failing. It now uses a leak-checking DebugAllocator with no stack traces. Dropping one of dial's frees still fails it, with the leak named. Closes #114.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
The cancellation test added in 0.14.4 dialled with
std.testing.allocator, which captures a stack trace on every allocation. On macOS that capture takes a lock which notices a pending cancel and swallows it, so a dial cancelled while still allocating would never return and the test would hang rather than fail. It passes today only because the dial is normally past its allocations by the time the cancel lands at 100 ms.It now dials with a
DebugAllocatorthat still checks for leaks but captures no stack traces. With one ofdial's frees removed, the test still fails and names the leak.Test only; nothing in the library changes. All 211 tests pass.