Notary is 0.10.12 - #101
Merged
Merged
Conversation
Carries the orphaned-keyholder fix. A keyholder whose app died was left running and holding the lock on the key, so the next launch was told another Notary already had it open. It notices now and goes. Cut so Plaza's pin can move to it before Plaza's own release: a Notary release is not finished until that pin moves, and shipping a Plaza that fixes the crash while still bundling a keyholder that strands the key on any other abnormal exit is half the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries #100, the orphaned keyholder.
A keyholder whose app died was left running and still holding the advisory lock on the key file, so the reader's next launch typed their passphrase and was told another Notary already had the key open. It was open, in a process nobody could see. Only the fifteen minute idle timer ever cleared it.
Cut now so Plaza's
NOTARY_REFcan move to it before Plaza's own release. A Notary release is not finished until that pin moves, and a Plaza that fixes its crash while still bundling a keyholder that strands the key on any other abnormal exit is half a fix.70/70 green.