Repository navigation
ci: a release goes public only once every artifact is up - #104
Merged
sepehr-safari merged 1 commit intoSep 25, 2026
Merged
Conversation
The publish job lifted the draft as soon as the macOS and Linux jobs exited 0 and claimed that meant every artifact was up. It now runs scripts/check-release-assets.sh first: every file a release of that tag should carry has to be listed by name, finished uploading and not empty, or the release stays a draft and the job names what is missing. The macOS job's branch for a release that already exists uploaded into it while it was public. It now turns it back into a draft first, and the lift goes through the API with make_latest=legacy, so a re-run of an older tag cannot take Latest from a newer one. The same change as Plaza's release workflow, which this one mirrors. Against v0.10.12 the check passes with all five files; CI runs its self-test.
sepehr-safari
deleted the
a-release-goes-public-only-once-every-artifact-is-up
branch
September 25, 2026 07:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes zig-nostr/plaza#362, together with zig-nostr/plaza#387, which makes the same change to Plaza's copy of this workflow.
publishrunsscripts/check-release-assets.shbefore lifting the draft: each expected file (Notary-vX.Y.Z-macos.zip, and each Linux tarball with its.sha256) must be listed, havestate == uploadedand a non-zero size. Otherwise the release stays a draft and the step names what is missing. It fails closed ifgherrors.gh apiwithdraft=falseandmake_latest=legacy, so re-running an older tag cannot move/releases/latest, which both installers read, back a version.Verified: the self-test passes (each negative case asserts which file was reported) and is shellcheck clean; against v0.10.12 the check passes with all five files. The check and the lift against a real draft run for the first time on the next release, and both fail closed.