The signing prompt can be read in any language - #98
Merged
Merged
Conversation
Two fields on the approval screen are not this window's text. The name of the
client asking for a signature is chosen by that client, and the preview is
whatever somebody is about to post. Off macOS the toolkit inks every glyph from
the one face it bundles, which covers Latin and Cyrillic, and paints a solid
filled rectangle for everything else. So a Japanese note came up as a row of
blocks on the one screen in this app that has to be read before somebody agrees
to it.
The window carries Noto for Greek, Japanese, Chinese and Korean now, and the
two Geist weights, which also fixes headings and buttons resolving to the
regular face and the whole window being one flat weight. 13 MB off macOS and
nothing on it, where CoreText draws the text and cascades to the system.
That needed the fork, which this window was not using. `native eject` had
written a machine-local path into somebody's npm directory:
.native_sdk = .{ .path = "../../../../.nvm/.../@native-sdk/cli" }
gitignored, so every runner and every contributor compiled against whatever
version of the command-line tool they happened to have, and a release was
whatever npm served that afternoon. A given Notary version did not mean one
thing. It is a commit pin now, the same shape Plaza has always had.
The framework is 0.10.1 with it, and the CLI pin in CI moves in this same
commit. They have to agree on the automation protocol and a mismatch does not
fail a build: it silently breaks every live test.
Notary is 0.10.11.
sepehr-safari
force-pushed
the
sdk-0-10-1-and-the-fork
branch
from
September 7, 2026 22:55
09f5657 to
f7907b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fields on the approval screen are not this window's text. The client's name is chosen by the client, and the preview is whatever somebody is about to post.
Off macOS the toolkit inks every glyph from the one face it bundles, which covers Latin and Cyrillic, and paints a solid filled rectangle for everything else. So a Japanese note came up as a row of grey blocks on the one screen in this app that has to be read before somebody agrees to it.
The window carries Noto for Greek, Japanese, Chinese and Korean now, plus the two Geist weights, which also fixes every heading and button resolving to the regular face and the whole window rendering at one flat weight. 13 MB off macOS and nothing on it, where CoreText draws the text and cascades to the system's own fonts.
Which needed the fork, and this window was not using it
native ejecthad written a machine-local path into somebody's npm directory, gitignored:So every CI runner and every contributor compiled against whatever version of the command-line tool they happened to have installed, and a release was whatever npm served that afternoon. A given Notary version did not mean one thing. Plaza has pinned the framework by commit since it existed; this is the same shape.
With the pin, Notary gets the two patches that are actually its own:
and the other two for free.
And the toolkit is 0.10.1
The CLI pin in CI moves in the same commit. They have to agree on the automation protocol, and a mismatch does not fail a build: it silently breaks every live test.
68 daemon tests unchanged. Notary is 0.10.11.