ci: check the optimized macOS link without timing it - #393
Merged
sepehr-safari merged 1 commit intoSep 25, 2026
Merged
Conversation
The ReleaseFast test step on the macOS runner ran the frame-time budgets on a shared VM roughly twice as slow as the machines they are set for: 17.9 ms against 16 there, 8 ms on an M2 Pro. It failed on timing with no code change. What the step was added for is the link (#389), and building the model-contract tool in ReleaseFast checks exactly that, since it carries the same toolkit host as the test binary, without running any tests. Removing the link fix makes it fail with the two undefined symbols; with the fix it passes. The Linux job keeps running the optimized suite.
sepehr-safari
deleted the
ci-checks-the-optimized-link-without-timing-it
branch
September 25, 2026 09:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #392
Replaces the macOS
zig build test -Doptimize=ReleaseFaststep from #390 withzig build model-contract -Doptimize=ReleaseFast.main.ziglink fix removed, this step fails with both_native_sdk_update_verify_*symbols undefined; with it, it passes. It runs no tests.