The page says what Plaza reads now - #35
Merged
Merged
Conversation
Three rows were out of date, two of them in the direction that matters: the page claimed as planned things that have been shipping for weeks. NIP-51 lists moved to the apps table. Bookmarks, public or private, and a mute list that is read before it is ever written. NIP-71 video moved with it. A video is recognised as one and drawn as one; playing it in place is still to come and the row says so rather than implying the whole spec. NIP-22 comments are new to the page entirely. It is the other way to write a reply, and Plaza reads it in threads, on a profile, and as a notification. The notifications sentence listed the NIPs it is assembled from and had gone stale the moment comments landed, so it names them now. And a sentence saying "three rows have a half already written, and say so" went with them. No row said so, before or after this change. A count that nothing backs up is worse than no count.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three rows on
/nipswere out of date, two of them in the direction that matters: the page called things planned that have been shipping for weeks.NIP-51 moves to the apps table. Bookmarks, public or private, and a mute list that is read before it is ever written. Shipped in v0.19.0.
NIP-71 moves with it. A video is recognised as one and drawn as one. Playing it in place is still to come, and the row says that rather than implying the whole spec. Shipped in v0.21.0.
NIP-22 is new to the page entirely. It is the other way to write a reply, and Plaza reads it in threads, on a profile, and as a notification. Shipped in v0.23.0.
The sentence listing which NIPs notifications is assembled from had gone stale the moment comments landed, so it names them now.
One more thing went with them. The planned section opened with "Three rows have a half already written, and say so". No row said so, before or after this change, so the count is gone rather than corrected. A number nothing backs up is worse than no number.
One I did not touch
The
ttag row is still listed as planned, and hashtags have worked since v0.19.0: pressing one opens the notes carrying it, read from the local store first. I left it because it is a fourth row and this PR is about the three, but it is wrong and worth its own look.