zwi syncs, benchmarks #1983
Open
zwi syncs, benchmarks #1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluidvanadium
changed the title
zancas
reviewed
Oct 30, 2025
| impl zcash_wallet_interface::Wallet for ZingoWallet { | ||
| fn user_agent_id() -> zcash_wallet_interface::UserAgentId { | ||
| const AGENT_NAME: &str = "zingo_wallet"; | ||
| const VERSION: &str = "0.0.1"; |
Member
There was a problem hiding this comment.
I advocated the removal of the foo.0 accessor.
Refactored zingo_wallet tests to use both Regtest and Testnet.
…h a lightserver. ... ..
fluidvanadium
force-pushed
the
zingo_wallet
branch
from
7f42e2c to
152e07b
Compare
fluidvanadium
changed the title
…stnet/glory_goddess/latest' --chain='testnet' --server='https://testnet.zec.rocks:443'
…stnet/glory_goddess/latest' --chain='testnet' --server='https://testnet.zec.rocks:443'
…allet changed. I was able to avert it in this merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The interface to zingolib is scattered over many modules. I wanted to re-imagine what the interface could look like.
What:
The sum of assumptions necessary to create a wallet with zingolib is contained in code here.
The only change made to the zingolib package so far is the correction of a chain_from_str function.
Tests:
So far, this creates a ZingoWallet.
And tests that it reports syncking a chain.
Notably, this test does not involve customized test behavior. It only uses the interface methods presented in zcash_wallet_interface.
Testnet Benchmarks are dependent on the network, so this leaves something to be desired for benchmarks.
TODO: nextest profile