Fix camera and grid interaction conflict - #2
Conversation
- Added modifier key (Shift/Ctrl) checks to `onMouseDown` and `onMouseMove` in `InputManager.ts` to prevent placing buildings or dragging roads while the user is using those keys to pan/rotate the camera. - Automatically cancels any active building drag if modifier keys are pressed during movement. Co-authored-by: zinkkrysty <570771+zinkkrysty@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added modifier key (Shift/Ctrl) checks to `onMouseDown` and `onMouseMove` in `InputManager.ts` to prevent placing buildings or dragging roads while the user is using those keys to pan/rotate the camera. - Automatically cancels any active building drag if modifier keys are pressed during movement. - Added Playwright end-to-end tests to verify modifier key behaviour correctly ignores grid interaction. Co-authored-by: zinkkrysty <570771+zinkkrysty@users.noreply.github.com>
1 participant
Fixes a bug where using Shift+Click or Ctrl+Click to control the camera in the 3D view would inadvertently trigger grid interactions, causing roads or buildings to be built/dragged unintentionally. The fix skips these events in
InputManagerwhen those modifier keys are held.PR created automatically by Jules for task 10942566378287052200 started by @zinkkrysty