test: Potential fixes for 3 code quality findings in tests/end_to_end.rs

[Pr0methean]

This PR applies 3/3 suggestions from code quality AI findings.

[gemini-code-assist]

Summary of Changes

Hello @Pr0methean, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements fixes for three identified code quality issues. It includes a refactoring of a test function to simplify compression method iteration, an update to a byte string literal for better handling of multi-line content, and an expansion of an existing test to ensure the correct mapping of ZIP extra field IDs.

Highlights

• Test Refactoring: The append test in tests/end_to_end.rs has been refactored to utilize a for_each_supported_method closure, which streamlines the iteration over compression methods and removes redundant conditional checks.
• String Literal Update: The LOREM_IPSUM constant in tests/end_to_end.rs was updated from a standard byte string literal (b"...") to a raw byte string literal (br#"..."#), improving readability and robustness for multi-line string definitions.
• Enhanced Extra Field Mapping Test: New assertions were added to test_extra_field_mapping_constants in tests/end_to_end.rs to verify the array bounds and the presence of specific well-known extra field IDs, such as Extended Timestamp (0x5455) and Info-ZIP Unix (0x7875), in the EXTRA_FIELD_MAPPING.

Changelog

• tests/end_to_end.rs
  • Refactored the append test function to use for_each_supported_method for cleaner iteration over compression methods.
  • Changed the LOREM_IPSUM constant to use a raw byte string literal (br#""#) for improved handling of multi-line text.
  • Added assertions to test_extra_field_mapping_constants to check for array length and the inclusion of specific extra field IDs (Extended Timestamp and Info-ZIP Unix).

Activity

• The changes in this pull request directly address and apply 3 out of 3 suggestions from automated code quality AI findings.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[amazon-q-developer]

The code changes in this PR are solid refactoring improvements that eliminate code duplication and add defensive bounds checking to tests. All three changes function correctly and don't introduce any defects.

Note: The PR title should follow Conventional Commits format and start with a type prefix (e.g., refactor: or chore: would be appropriate here).

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[gemini-code-assist]

Code Review

This pull request applies three automated code quality suggestions. While two of the changes are good improvements, the third one, which adds assertions to a test, introduces a new failing test. I've pointed out the critical issue with the failing test and also suggested a medium-severity improvement to make the test more robust by using a consistent assertion style.

[gemini-code-assist]

This assertion will fail because 0x5455 (corresponding to UsedExtraField::ExtendedTimestamp) is not present in the EXTRA_FIELD_MAPPING constant array in src/extra_fields/mod.rs. This pull request introduces a failing test. Please either add the value to EXTRA_FIELD_MAPPING or remove this assertion.