Skip to content

Conversation

@Pr0methean
Copy link
Member

Fails spuriously, apparently because secrets aren't substituted into script body.

Fails spuriously, apparently because secrets aren't substituted into script body.

Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@Pr0methean Pr0methean enabled auto-merge February 10, 2026 20:34
Copy link
Contributor

@amazon-q-developer amazon-q-developer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the secret validation check is correct. GitHub Actions doesn't substitute secrets into shell script bodies for security reasons, making the removed check fundamentally flawed—it would always see an empty string regardless of whether the secret is configured. The secret is properly used on line 21 where it's passed directly to the action's with: parameter, which is the correct approach. If the secret is missing, the create-github-app-token action will fail with an appropriate error message, providing the same safeguard without spurious failures.

The PR title correctly follows the Conventional Commits format with the ci: prefix as required by the guidelines.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@Pr0methean Pr0methean added this pull request to the merge queue Feb 10, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant