feat: Sign the full SAML response and attach the Signature#102
Merged
stebenz merged 2 commits intoOct 30, 2025
Conversation
Add a signature for the whole response
Member
|
Sorry for the late reply. I'll look into this by the end of this week. |
|
hey @ttradesman firstly, thank you for your contribution and also, very sorry for the delay. Livio is on holiday at the moment, so we'll assign the review to another engineer. Thank you for the patience! |
stebenz
approved these changes
Oct 30, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 47.36% 50.47% +3.10%
==========================================
Files 21 26 +5
Lines 1974 2001 +27
==========================================
+ Hits 935 1010 +75
+ Misses 981 920 -61
- Partials 58 71 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to integrate the AWS Client VPN with Zitadel via SAML2 as the SSO solution to login to the VPN. However, as described in the AWS docs: "The SAML assertion and SAML documents must be signed." – and Zitadel only delivers a signed assertion in its response.
These code changes fixes this issues, and successfully signs the full response.
Reference: https://discord.com/channels/927474939156643850/1389861642854072343/1389861642854072343
See issue #103.
Definition of Ready