Skip to content

feat: Sign the full SAML response and attach the Signature#102

Merged
stebenz merged 2 commits into
zitadel:mainfrom
ttradesman:ttradesman-sign-complete-response
Oct 30, 2025
Merged

feat: Sign the full SAML response and attach the Signature#102
stebenz merged 2 commits into
zitadel:mainfrom
ttradesman:ttradesman-sign-complete-response

Conversation

@ttradesman
Copy link
Copy Markdown
Contributor

@ttradesman ttradesman commented Jul 3, 2025

We want to integrate the AWS Client VPN with Zitadel via SAML2 as the SSO solution to login to the VPN. However, as described in the AWS docs: "The SAML assertion and SAML documents must be signed." – and Zitadel only delivers a signed assertion in its response.

These code changes fixes this issues, and successfully signs the full response.

Reference: https://discord.com/channels/927474939156643850/1389861642854072343/1389861642854072343

See issue #103.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Add a signature for the whole response
@ttradesman ttradesman changed the title Update post.go feat: Sign the full SAML response and attach the Signature Jul 3, 2025
@livio-a
Copy link
Copy Markdown
Member

livio-a commented Oct 8, 2025

Sorry for the late reply. I'll look into this by the end of this week.

@livio-a livio-a self-requested a review October 8, 2025 08:16
@elinashoko elinashoko moved this to 📋 Sprint Backlog in Product Management Oct 23, 2025
@elinashoko elinashoko removed the request for review from livio-a October 23, 2025 16:10
@elinashoko
Copy link
Copy Markdown

hey @ttradesman firstly, thank you for your contribution and also, very sorry for the delay. Livio is on holiday at the moment, so we'll assign the review to another engineer. Thank you for the patience!

@elinashoko elinashoko requested a review from stebenz October 24, 2025 09:42
@stebenz stebenz enabled auto-merge (squash) October 30, 2025 09:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.47%. Comparing base (524a649) to head (9b82f27).
⚠️ Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
pkg/provider/post.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   47.36%   50.47%   +3.10%     
==========================================
  Files          21       26       +5     
  Lines        1974     2001      +27     
==========================================
+ Hits          935     1010      +75     
+ Misses        981      920      -61     
- Partials       58       71      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stebenz stebenz merged commit 4a954b1 into zitadel:main Oct 30, 2025
5 checks passed
@github-project-automation github-project-automation Bot moved this from 📋 Sprint Backlog to ✅ Done in Product Management Oct 30, 2025
@github-actions
Copy link
Copy Markdown

ghost commented Oct 30, 2025

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants