fix: allow redirect to correct AssertionConsumerServiceURL when there are multiple with the same Binding#105
Merged
stebenz merged 4 commits intoOct 30, 2025
Conversation
Also adds support for the AssertionConsumerServiceIndex feature.
Added new tests for the changed behaviour of the GetAcsUrlAndBindingForResponse function.
stebenz
approved these changes
Oct 30, 2025
|
🎉 This PR is included in version 0.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in relation to issue #104, see this issue for a description of the issue this PR solves. I've tried my best with updating tests etc, but I expect there are more improvements to be made based on the maintainers input.
Definition of Ready