Skip to content

fix: allow redirect to correct AssertionConsumerServiceURL when there are multiple with the same Binding#105

Merged
stebenz merged 4 commits into
zitadel:mainfrom
ttradesman:ttradesman-multiple-bindings-different-locations
Oct 30, 2025
Merged

fix: allow redirect to correct AssertionConsumerServiceURL when there are multiple with the same Binding#105
stebenz merged 4 commits into
zitadel:mainfrom
ttradesman:ttradesman-multiple-bindings-different-locations

Conversation

@ttradesman
Copy link
Copy Markdown
Contributor

This PR is in relation to issue #104, see this issue for a description of the issue this PR solves. I've tried my best with updating tests etc, but I expect there are more improvements to be made based on the maintainers input.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Also adds support for the AssertionConsumerServiceIndex feature.
Added new tests for the changed behaviour of the GetAcsUrlAndBindingForResponse function.
@livio-a livio-a requested a review from stebenz October 30, 2025 09:50
@stebenz stebenz enabled auto-merge (squash) October 30, 2025 10:33
@stebenz stebenz changed the title Allow redirect to correct AssertionConsumerServiceURL when there are multiple with the same Binding fix: allow redirect to correct AssertionConsumerServiceURL when there are multiple with the same Binding Oct 30, 2025
@stebenz stebenz disabled auto-merge October 30, 2025 10:33
@stebenz stebenz enabled auto-merge (squash) October 30, 2025 10:34
@stebenz stebenz merged commit 464bf90 into zitadel:main Oct 30, 2025
3 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 0.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants