fix(metadata): metadata order#106
Merged
Merged
Conversation
stebenz
approved these changes
Sep 4, 2025
|
🎉 This PR is included in version 0.3.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
IAM-marco
added a commit
to zitadel/zitadel
that referenced
this pull request
Sep 4, 2025
# Which Problems Are Solved The change partially addresses #5630 , specifically the part about "Order of SAML attributes are non-compliant". # How the Problems Are Solved - Upgrade of the zitadel SAML library # Additional Context - Partially addresses #5630 - Depends on zitadel/saml#106
livio-a
pushed a commit
to zitadel/zitadel
that referenced
this pull request
Sep 8, 2025
# Which Problems Are Solved The change partially addresses #5630 , specifically the part about "Order of SAML attributes are non-compliant". # How the Problems Are Solved - Upgrade of the zitadel SAML library # Additional Context - Partially addresses #5630 - Depends on zitadel/saml#106 (cherry picked from commit 8cc79c1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition of Ready
Which problems are fixed
This change is addressing the issue zitadel/zitadel#5630 , specifically the part "Order of SAML attributes are non-compliant" .
How are problems are fixed
The change entails changing the order of the parameters of the 2 structs
IDPSSODescriptorTypeandAttributeAuthorityDescriptorTypeaccording to what is described in https://groups.oasis-open.org/higherlogic/ws/public/download/51890/SAML%20MD%20simplified%20overview.pdf/latest and https://shibboleth.atlassian.net/wiki/spaces/CONCEPT/pages/928645275/MetadataForIdPReferences