Merged
Conversation
95DDB
approved these changes
Mar 2, 2026
Collaborator
95DDB
left a comment
95DDB
left a comment
There was a problem hiding this comment.
Please fix linter, all good
la10736
approved these changes
Mar 2, 2026
| mod should { | ||
| use super::*; | ||
|
|
||
| #[rstest] |
Collaborator
There was a problem hiding this comment.
For the next ime. don't use rstest if you don't really need it
Collaborator
There was a problem hiding this comment.
Maybe you started with it because you would use values from 1..=CONST_PROOF_SIZE_LOG_N and then discovered that it was not possible.
Contributor
Author
There was a problem hiding this comment.
Yes, exactly. I replaced these attributes with #[test].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply adds functionality for deriving the value of
log_nfrom the proof length. This aims to enable zkVerify to charge more fairly (i.e., based on the value oflog_n, instead of always using the maximum value oflog_n).