Skip to content

Allow transcript labels to come from non-Rust code#6

Open
alinush wants to merge 1 commit intozkcrypto:mainfrom
aptos-labs:main
Open

Allow transcript labels to come from non-Rust code#6
alinush wants to merge 1 commit intozkcrypto:mainfrom
aptos-labs:main

Conversation

@alinush
Copy link
Copy Markdown

@alinush alinush commented Sep 2, 2022

Addresses dalek-cryptography#44.

This enables exporting a more versatile Bulletproof range proof verifier inside smart contracts (e.g., see Aptos and Sui).

Specifically, it allows smart contract developers to dynamically specify their domain separation tag (DST) in Transcript::new. This can be necessary in the smart contract setting where different smart contracts will verify proofs from different provers, each with an application-specific DST that might have been established years prior (e.g., think about verifying previously-computed Monero range proofs).

@gregnazario
Copy link
Copy Markdown

gregnazario commented Jul 27, 2023

Hey @hdevalence could we get this reviewed and merged? Currently, any consumers using this patch have to apply it to themselves as well. Or is it @str4d who's the owner?

aptos-labs/aptos-core#9340

@gregnazario
Copy link
Copy Markdown

@hdevalence or @str4d could you take a look at this?

@gregnazario
Copy link
Copy Markdown

@hdevalence @str4d ?

@str4d
Copy link
Copy Markdown
Member

str4d commented Nov 21, 2023

This is not my crate; @hdevalence has the publish bit.

@hdevalence
Copy link
Copy Markdown
Collaborator

Hey, sorry about the delayed follow-up. As the history indicates, I haven't had capacity to maintain the crate. Happy to turn over maintenance and crates.io ownership to someone who does.

@alinush
Copy link
Copy Markdown
Author

alinush commented Nov 21, 2023

Hey, sorry about the delayed follow-up. As the history indicates, I haven't had capacity to maintain the crate. Happy to turn over maintenance and crates.io ownership to someone who does.

@hdevalence, I am happy to adopt responsibility for the crate. I DM'd you my email address on Telegram.

@HarryR
Copy link
Copy Markdown

HarryR commented Dec 23, 2024

This seems like an entirely sane easy merge PR.

Just press the button

@gregnazario
Copy link
Copy Markdown

@hdevalence @alinush let's get this pushed?

@HarryR
Copy link
Copy Markdown

HarryR commented Jan 6, 2025

Either that or we can just fork the repo, iirc hdv said he doesn't have time to maintain this any more.

/target
**/*.rs.bk
Cargo.lock
/.idea
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary, just add it to your .git/info/exclude file locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants