Skip to content

Add base leg valuation for synthetic perp markets in Drift adapter#36

Closed
zknpr wants to merge 1 commit intomainfrom
drift-base-leg-valuation-864869628374530130
Closed

Add base leg valuation for synthetic perp markets in Drift adapter#36
zknpr wants to merge 1 commit intomainfrom
drift-base-leg-valuation-864869628374530130

Conversation

@zknpr
Copy link
Copy Markdown
Owner

@zknpr zknpr commented Feb 15, 2026

This PR addresses the issue where base leg valuation was skipped for perp markets lacking a spot mint (e.g., HYPE-PERP).

Changes:

  • In projects/neutral-trade/utils/drift.js, within getTvl, modified the perpPositions processing loop.
  • Added logic to the else block (where baseTokenMint is missing) to fetch the PerpMarket account info.
  • Implemented parsing of last_oracle_price from the HistoricalOracleData struct within the PerpMarket account (specifically at offset 72).
  • Calculated the USD value of the base position using the formula: (base_asset_amount * last_oracle_price) / 1e9. The division by 1e9 accounts for the base asset precision (1e9) and oracle price precision (1e6) to produce a result in USDC precision (1e6).
  • The calculated value is added to the USDC balance using api.add.

This ensures that the TVL/Equity calculation correctly includes the value of positions in synthetic perp markets. Verified via a temporary test script mocking the buffer read and calculation.


PR created automatically by Jules for task 864869628374530130 started by @zknpr

- Implemented manual reading of `last_oracle_price` from `PerpMarket` account data (offset 72).
- Calculated USD value of base asset for markets without a spot mint (e.g., HYPE-PERP).
- Added value to quote token (USDC) balance in TVL calculation.

Co-authored-by: zknpr <96851588+zknpr@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 15, 2026

Warning

Rate limit exceeded

@zknpr has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2d20682 and 1ddfbf9.

📒 Files selected for processing (1)
  • projects/neutral-trade/utils/drift.js
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drift-base-leg-valuation-864869628374530130

Comment @coderabbitai help to get the list of available commands and usage tips.

@zknpr
Copy link
Copy Markdown
Owner Author

zknpr commented Mar 8, 2026

Closing: duplicate of PR #73 (drift base leg pricing). #73 has better comments explaining precision and includes null checks.

@zknpr zknpr closed this Mar 8, 2026
@google-labs-jules
Copy link
Copy Markdown

Closing: duplicate of PR #73 (drift base leg pricing). #73 has better comments explaining precision and includes null checks.

Understood. Acknowledging that this work is a duplicate of PR #73 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant