Calculate USD value for Drift perps without spot mint#44
Conversation
Implemented logic to read the last oracle price from the Drift V2 PerpMarket account and calculate the USD value for positions where the base token mint is missing (e.g. HYPE-PERP). This resolves a TODO in projects/neutral-trade/utils/drift.js. Co-authored-by: zknpr <96851588+zknpr@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Implemented the TODO in
projects/neutral-trade/utils/drift.jsto calculate the USD value of perpetual positions that do not have a corresponding spot token mint (e.g., points markets or pre-launch markets like HYPE-PERP).The fix involves:
PerpMarketaccount info from the cachedperpAccountMap.last_oracle_pricedirectly from the account data at offset 72 (corresponding toamm.historical_oracle_data.last_oracle_pricein Drift V2 layout).(base_asset_amount * price) / 10^9, assuming standard Drift precision (9 decimals for base asset, 6 decimals for price/quote).apiaccumulator as USDC.This ensures that TVL for markets like HYPE-PERP is correctly accounted for.
Verified logic with targeted scripts checking offsets and values against live mainnet data.
PR created automatically by Jules for task 9575155516090815336 started by @zknpr