Repository navigation
feat: Add baseline test infrastructure for Temporal proposal - #1541
Raymondo97 wants to merge 3 commits into
Conversation
|
I did want to mention that the reason I decided to put the tests into a separate directory under the |
|
The changes made here do not pass the ESLint rules. I will mark the PR as ready when it succeeds, and the corrections are pushed up. |
Interesting. According to the ESLint rules, it shouldn’t pass. Especially for the |
5e541f4 to
d92edbe
Compare
|
@stasyu2009-ux if you wanna say something, please, use English. |
|
@Raymondo97 sorry for the delayed reply. I am now fully focused on other tasks, I'll take a look in the next few days. |
a683130 to
fe4b4c1
Compare
|
@zloirock No worries at all! I see that you've been working incredibly hard on v4. To be clear, this PR establishes the However, as I look at porting the rest of the Temporal tests from Test262, I'm realizing the sheer volume will be massive. Moving forward, I'm wondering if it may be beneficial to match Test262's layout. We could group the tests into sub-directories inside an In order to support this, we'd need to decide how to apply ESLint settings to it. By hardcoding the (Note: to support importing folders like this in the future, I already included a small regex fix to Would this nested approach align with your vision for the v3/v4 architecture, or would you prefer a different layout before I start porting the rest of the Test262 suite? I'll hold off on porting the massive test suites until I hear your thoughts on the architecture. I'm happy to adjust as needed! |
|
Hey @zloirock, I saw that compat data mapping was recently added for Node 26 (which includes native I'm still happy to continue porting the remaining Test262 sub-suites if this is helpful, or pivot if you have other priorities for |
This PR introduces the initial testing infrastructure and baseline specification tests for the upcoming Temporal proposal.
To ensure the test suite is manageable and easy to review, this initial PR focuses strictly on setting up the shared harness infrastructure, upgrading the build scripts to support future test suites, and providing a single flat baseline test for the Temporal namespace.
Key Changes
.gitignoreto prevent local IDE files from polluting the working tree..replace(/\.js$/, '')) toscripts/build-indexes.mjs. This allows the index generator to safely handle future directory-based test suites (likees.temporal/duration/) without inadvertently slicing folder names.tests/helpers/temporal-helpers.js, porting vital assertion macros (e.g.,assertDuration) and ISO constants from Test262. Assertions have been refactored to rely on passing the localized test framework context rather than assuming a leaked global context.tests/unit-global/es.temporal.jsandtests/unit-pure/es.temporal.js) to verify the root namespace and basic descriptor intents (using safe target checks likeObject.isExtensible).Architectural Guardrails Included
if (DESCRIPTORS)environments to maintain compatibility with legacy testing engines.core-js-pure.