Migrate Google Play deployment to Workload Identity Federation - #2052
Open
y4ssi wants to merge 1 commit into
Open
Migrate Google Play deployment to Workload Identity Federation#2052y4ssi wants to merge 1 commit into
y4ssi wants to merge 1 commit into
Conversation
Replace static service account JSON key with WIF for improved security: - Update deploy.yml to use google-github-actions/auth with WIF - Modify Gradle publish task to support both WIF credentials file and legacy JSON key - Enable temporary credential generation instead of long-lived keys Required GitHub secrets in deployment environment: - GOOGLE_PLAY_CLOUD_PROJECT - GOOGLE_PLAY_SERVICE_ACCOUNT - GOOGLE_PLAY_WORKLOAD_IDENTITY_PROVIDER - GOOGLE_PLAY_PUBLISHER_API_KEY
y4ssi
changed the title
6 tasks
nesence-m
reviewed
Dec 22, 2025
| it.createScoped(listOf(AndroidPublisherScopes.ANDROIDPUBLISHER)) | ||
| } | ||
| private fun getCredential(serviceKeyFilePath: String, serviceKeyJson: String): GoogleCredentials { | ||
| return if (serviceKeyFilePath.isNotEmpty() && File(serviceKeyFilePath).exists()) { |
Contributor
There was a problem hiding this comment.
use 'when' instead of 'if' when there are 3+ branches
| .also { | ||
| it.createScoped(listOf(AndroidPublisherScopes.ANDROIDPUBLISHER)) | ||
| } | ||
| private fun getCredential(serviceKeyFilePath: String, serviceKeyJson: String): GoogleCredentials { |
Contributor
There was a problem hiding this comment.
so json will either be in file already or it will be in json from env variable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace static service account JSON key with WIF for improved security:
Required GitHub secrets in deployment environment: