Facebook SDK update + Facebook JavaScript snippet view - #5
Open
kstep wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I liked your module for its simplicity and straightforwardness, but it doesn't work with new Facebook SDK, so I updated it (also had to do some changes in code in order to make Kohana glue class work with FbSDK correctly).
Also I added facebook-js view, so users can choose to do
<?=View::factory('facebook-js')?>in their views to integrate FB seamlessly.I guess you ceased development efforts on the module (as the last change in your repo dates 2 years ago) so you maybe not interested in the module now, but anyway I thought I should notify you about my changes as an original author of the module.
And if you don't support it any more, would you mind if I take your code for maintenance?
Anyway thank you for your module, it's proved most handy for me.