Open
Conversation
- Change query type to DNSKEY - Remove uneeded conditionals - Add a mention for missing unit tests
|
|
||
| if ( $p ) { | ||
| if ( $p->rcode eq q{FORMERR} and not $p->edns_rcode ) { | ||
| if ( $p->rcode eq q{FORMERR} ) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ( $p->rcode eq q{FORMERR} ) { | |
| if ( $p->rcode eq q{FORMERR} and not $p->has_edns ) { |
A non-EDNS FORMERR response means the server does not support EDNS, in which case it is appropriate to generate a NO_EDNS_SUPPORT message. But an EDNS-enabled FORMERR response means something else: that the server understood that the query is an EDNS query, but it is malformed. In that case we should generate NS_ERROR.
Contributor
Author
There was a problem hiding this comment.
Maybe so, but that is not what the current specification is saying and this PR was about correcting discrepancies. I'm fine with reverting this change though until a proper specification update is done.
@matsduf thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR proposes to fix discrepancies in the implementation of Nameserver13 with respect to its specification.
Context
Fixes #1503
Changes
How to test this PR
This test case (among others in this test module) currently have no unit test. See
Manual testing: