Skip to content

ci.yml's frozen-string-literal RUBYOPT never applies: startsWith(matrix.ruby-version, '3.4.') against "3.4" #170

Description

@mhenrixon

.github/workflows/ci.yml:102 sets RUBYOPT: ${{ startsWith(matrix.ruby-version, '3.4.') && '--enable=frozen-string-literal' || '' }}. The matrix values (ci.yml:51-55) are "3.2", "3.3", "3.4" with no trailing dot, so startsWith(..., '3.4.') is false on every cell and the frozen-string-literal run the option was meant to add has never happened.

Fix shape: match on '3.4' (or compare equality), and confirm a 3.4 job log shows --enable=frozen-string-literal in effect; expect that first real run to surface any string mutation the suite has been hiding.

Found while seeding the lode (see the chore: seed the lode PR); lode/testing-and-ci/summary.md states the current behaviour and links here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions