Packaging refactor + Rpm parameters fix by sachintu47 · Pull Request #1191 · zopencommunity/meta

sachintu47 · 2026-05-22T12:07:08Z

What type of PR is this? (check all applicable)

Description

Updates bin/zopen-build to move pax/RPM generation and activation out of install() into dedicated helpers (create_pax, create_rpm, finalize_pax_metadata, set_active_version) and a new package() step
Enhances RPM creation to pass explicit name/version/release values and filters meta out of runtime requirements.

Related Issues

Related Issue #
Closes #

[optional] Are there any post-deployment tasks or follow-up actions required?

sachintu47 · 2026-05-22T12:09:03Z

augment review

augmentcode · 2026-05-22T12:12:58Z

🤖 Augment PR Summary

Summary: Refactors the zopen build workflow to separate installation, packaging, OCI publishing, and activation into clearer phases.

Changes:

Updates bin/zopen-build to move pax/RPM generation and activation out of install() into dedicated helpers (create_pax, create_rpm, finalize_pax_metadata, set_active_version) and a new package() step.
Adjusts the main execution flow to run package() only when --generate-pax/--generate-rpm are set, run generateOCI only when --publish-oci is enabled, and activate only when --set-active is requested.
Enhances RPM creation to pass explicit name/version/release values and filters meta out of runtime requirements.
Adds a --build-binary option to bin/zopen-pax2rpm and updates the rpmbuild invocation flow to support binary-only builds.
Improves CI release description generation (cicd/publish.groovy) by including version, test status, runtime deps, build deps, and an example install command snippet.
Bumps the framework version to 0.8.5.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-05-22T12:12:59Z

+pax_finalize()
+{
+  #TODO: Hack so that we can use coreutils md5sum without impacting builds
+  ZOPEN_DEPS="coreutils jq"


pax_finalize() resets ZOPEN_DEPS to just coreutils jq, which changes what setDepsEnv will (re)install/re-source for the rest of the run and may unintentionally drop other dependency environments that were previously active. This also mutates the global ZOPEN_DEPS value after install, which could surprise later steps (e.g., OCI publish / activate).

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

sachintu47 · 2026-05-22T14:42:38Z

augment review

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

sachintu47 · 2026-05-24T17:05:57Z

augment review

augmentcode

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

sachintu47 · 2026-05-25T03:45:08Z

augment review

augmentcode

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

sachintu47 · 2026-05-25T05:25:20Z

augment review

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

sachintu47 · 2026-05-25T06:03:19Z

augment review

augmentcode

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

Extract inline packaging code into separate functions for better maintainability and code organization.

Add timestamp-based RPM release numbering to prevent CI build overwrites. Add --build-binary flag to zopen-pax2rpm for faster binary-only builds. Update zopen-build to use binary-only builds by default.

Filter out 'meta' from ZOPEN_RUNTIME_DEPS when generating RPM requires list.

…e_version() The set_active_version() function was using an undefined variable 'name' when creating the profiled directory path and dotenv file. This was introduced during the refactoring in commit 345ac3f. Fixed by using PROJECT_NAME which is already defined at the beginning of the function.

Previously, rpmbuild output was captured but never displayed, making it difficult to diagnose failures when the error message said 'review the spec file and build output above'. Changes: - Capture and display rpmbuild output for both -bb and -ba modes - Store exit code separately for proper error checking - Only show Source RPMs section when not using --build-binary flag

Changed set_active_version() to use getProjectName() instead of cut -d'-' -f1 to properly handle hyphenated port names and maintain consistency with other parts of the codebase (RPM naming, metadata generation, zopen-install). This ensures mergeIntoSystem updates the correct project key/directory for ports with hyphens in their names. Also fixed setup.sh to run in a subshell to avoid changing the working directory for later steps like ZOPEN_PRE_TERMINATE_CODE.

sachintu47 · 2026-05-25T11:52:07Z

/run tests

IgorTodorovskiIBM

LGTM

augmentcode Bot reviewed May 22, 2026

View reviewed changes

Comment thread bin/zopen-build Outdated

Comment thread bin/zopen-build Outdated

Comment thread bin/zopen-pax2rpm Outdated

augmentcode Bot reviewed May 24, 2026

View reviewed changes

Comment thread bin/zopen-build Outdated

Comment thread bin/zopen-build

augmentcode Bot reviewed May 25, 2026

View reviewed changes

Comment thread bin/zopen-build

Comment thread bin/zopen-build Outdated

sachintu47 force-pushed the packaging_refactor branch from 55911b9 to 06a9c5e Compare May 25, 2026 05:22

augmentcode Bot reviewed May 25, 2026

View reviewed changes

Comment thread bin/zopen-build

Comment thread bin/zopen-build

Comment thread bin/zopen-pax2rpm

sachintu47 force-pushed the packaging_refactor branch from 06a9c5e to 33617c1 Compare May 25, 2026 05:40

sachintu47 marked this pull request as ready for review May 25, 2026 06:03

sachintu47 requested review from DevonianTeuchter, HarithaIBM, IgorTodorovskiIBM, MikeFultonDev and v1gnesh as code owners May 25, 2026 06:03

sachintu47 changed the title ~~Packaging refactor~~ Packaging refactor + Rpm parameters fix May 25, 2026

augmentcode Bot reviewed May 25, 2026

View reviewed changes

Comment thread bin/zopen-build

Comment thread bin/zopen-build

augmentcode Bot reviewed May 25, 2026

View reviewed changes

Comment thread bin/zopen-build Outdated

Comment thread bin/zopen-build

Comment thread cicd/publish.groovy

sachintu47 force-pushed the packaging_refactor branch from 33617c1 to 03fd43b Compare May 25, 2026 08:50

sachintu47 added 6 commits May 25, 2026 14:25

fix: add version and install instructions to releases

755ed38

refactor(zopen-build): modularize packaging workflow

4997679

Extract inline packaging code into separate functions for better maintainability and code organization.

improve package() dependency management

7aec184

feat(rpm): add dynamic release numbering and binary-only builds

c29fa83

Add timestamp-based RPM release numbering to prevent CI build overwrites. Add --build-binary flag to zopen-pax2rpm for faster binary-only builds. Update zopen-build to use binary-only builds by default.

fix(rpm): exclude 'meta' package from RPM dependencies

8230f9a

Filter out 'meta' from ZOPEN_RUNTIME_DEPS when generating RPM requires list.

sachintu47 added 2 commits May 25, 2026 14:25

sachintu47 force-pushed the packaging_refactor branch from 03fd43b to 1a6d2f1 Compare May 25, 2026 08:55

sachintu47 changed the base branch from main to fix_zopen_init May 25, 2026 08:57

Base automatically changed from fix_zopen_init to main May 25, 2026 09:04

IgorTodorovskiIBM reviewed May 25, 2026

View reviewed changes

Comment thread bin/zopen-build Outdated

IgorTodorovskiIBM reviewed May 25, 2026

View reviewed changes

Comment thread bin/zopen-pax2rpm

IgorTodorovskiIBM approved these changes May 25, 2026

View reviewed changes

Path setting not needed. Implicit deps path added by default

298ebfb

sachintu47 merged commit f6dcff3 into main May 25, 2026
1 of 2 checks passed

sachintu47 deleted the packaging_refactor branch May 25, 2026 14:07

Conversation

sachintu47 commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this? (check all applicable)

Category

Description

Related Issues

[optional] Are there any post-deployment tasks or follow-up actions required?

Uh oh!

sachintu47 commented May 22, 2026

Uh oh!

augmentcode Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sachintu47 commented May 22, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sachintu47 commented May 24, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sachintu47 commented May 25, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sachintu47 commented May 25, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sachintu47 commented May 25, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sachintu47 commented May 25, 2026

Uh oh!

Uh oh!

Uh oh!

IgorTodorovskiIBM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

sachintu47 commented May 22, 2026 •

edited

Loading

augmentcode Bot commented May 22, 2026 •

edited

Loading

augmentcode Bot May 22, 2026 •

edited

Loading