fix: Updates on JVM console encoding#4495
Conversation
Signed-off-by: hrishikesh-nalawade <hrishikesh.nalawade.17@gmail.com>
github-project-automation
bot
moved this to New
in API Mediation Layer Backlog Management
| JAVA_VERSION=$(${JAVA_HOME}/bin/javap -J-Xms4m -J-Xmx16m -verbose java.lang.String \ | ||
| | grep "major version" \ | ||
| | cut -d " " -f5) | ||
| | awk '{print $NF}') |
There was a problem hiding this comment.
what is the background of this change? Can you expand on what scenario breaks with the original code?
There was a problem hiding this comment.
With the changes introduced in PR #4482 and based on the initial round of testing, those characters were not present. However, last week, one of our teammates noticed the characters appearing at different location in log file while testing some other issue. I revalidated this on my end and confirmed that the characters are indeed present.
To further investigate the root cause, I’ve applied the above changes to examine whether an additional space delimiter might be getting introduced with the Java version. By using $NF, I was just testing out this suspicion.
There was a problem hiding this comment.
update:- I tested this new changes as well, but still I can see those heliographic characters.
EvaJavornicka
moved this from New
to In Progress
in API Mediation Layer Backlog Management
|
Closing this PR as the working solution for this issue has been given in PR #4504 |
github-project-automation
bot
moved this from In Progress
to Done
in API Mediation Layer Backlog Management
hrishikesh-nalawade
deleted the
hrishikesh-nalawade/GH4419/updated-console-encoding
branch
3 participants
Description
Further updates on the previous PR. #4482
Linked to #4419
Type of change