EASY Fix: Enable Wildcard Subdomains w/ Just 2 Characters#232
Open
jeromyjclark wants to merge 2 commits intozpanel:masterfrom
Open
EASY Fix: Enable Wildcard Subdomains w/ Just 2 Characters#232jeromyjclark wants to merge 2 commits intozpanel:masterfrom
jeromyjclark wants to merge 2 commits intozpanel:masterfrom
Conversation
At or around line 251, in the 'static function IsValidDomainName($a)', simply add '\*' into the first group so that the form will also accept an asterisk along with numbers, letters and hyphens within a subdomain name. When the daemon/cron runs its process -everything falls into place. In other words - it will work just like adding a subdomain using cPanel.
What this does is give the ability to create wildcard subdomains for users with packages that include "unlimited subdomains" - while preventing that capability for everyone else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At or around line 251, in the 'static function IsValidDomainName($a)', simply add '*' into the first group so that the form will also accept an asterisk along with numbers, letters and hyphens within a subdomain name. When the daemon/cron runs its process -everything falls into place. In other words - it will work just like adding a subdomain using cPanel.