Repository navigation
Conversation
Fix drift between docs/component-vocabulary.md and src/components/index.js: - Move <agent-copy-block>, <agent-tabs>/<agent-tab>, and <agent-timeline>/<agent-step> from "Planned components" to "Supported components" with accurate attribute tables, behavior, accessibility, and trust notes. - Correct <agent-step>: uses `label` (not `title`), has no `time` attribute, and its status vocabulary is done|active|pending|failed (unknown -> pending), not todo/doing/blocked/skipped. - Document previously-undocumented <agent-action-list>/<agent-action> (layout, group-by, filter-status, filter-priority, show-done; item owner/due/priority/status; body text as the visible label). - Document previously-undocumented <agent-proceed> (label, allow-empty; agent-isles:select listener; composed agent-isles:proceed event; disabled-until-selected and processing states). Mirror all changes to docs/wiki/Component-Vocabulary.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RjhixerKDdj4Fg5NuqHwk4
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent Isles component vocabulary documentation (and its wiki mirror) to better match the currently implemented/exported <agent-*> components, promoting several components to “supported” and adding missing component docs.
Changes:
- Added/expanded “supported” documentation for
<agent-copy-block>,<agent-tabs>/<agent-tab>, and<agent-timeline>/<agent-step>. - Added new documentation for
<agent-action-list>/<agent-action>and<agent-proceed>. - Reorganized “Planned components” so
<agent-finding>remains listed as planned.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| docs/component-vocabulary.md | Updates the canonical component vocabulary reference, adding/expanding docs for supported components and moving the planned section. |
| docs/wiki/Component-Vocabulary.md | Mirrors the same vocabulary changes into the repo-tracked wiki page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Each `<agent-step>` contains concise details, links, or evidence for that step. | ||
|
|
||
| Accessibility notes: | ||
|
|
| <agent-timeline label="Autopilot run"> | ||
| <agent-step status="done" label="Inspected issue"> | ||
| Confirmed #10 was ready and no existing PR targeted it. | ||
| </agent-step> |
| Confirmed #10 was ready and no existing PR targeted it. | ||
| </agent-step> | ||
| <agent-step status="doing" title="Open PR"> | ||
| <agent-step status="active" label="Open PR"> |
| Authoring guidance: | ||
|
|
||
| - Use `<agent-action-list>` for the container and direct `<agent-action>` children for items. | ||
| - Put the visible action text in the element body; `<agent-action>` has no label attribute, and items with empty body text are skipped. |
|
|
||
| Child content: | ||
|
|
||
| - `<agent-action-list>` should contain direct `<agent-action>` children. |
|
|
||
| Example: | ||
|
|
||
| ```markdown |
| Example: | ||
|
|
||
| ```markdown | ||
| <agent-action-list label="Launch follow-ups" layout="table" group-by="status" filter-status="open,in-progress,blocked" show-done="false"> |
|
|
||
| ### `<agent-proceed>` | ||
|
|
||
| Use as the deliberate "go" / commit control on live brainstorming screens: readers explore options with `<agent-option-set>`/`<agent-choice>`, then advance with `<agent-proceed>`. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/component-vocabulary.mdhad drifted fromsrc/components/index.js: several components that are implemented and exported were still listed as "Planned", and two others were entirely undocumented. This PR reconciles the reference (and its wiki mirror) with the actual implementation.Changes
<agent-copy-block>(label,lang)<agent-tabs>/<agent-tab>(label;title,active)<agent-timeline>/<agent-step><agent-step>spec to matchsrc/components/agent-timeline.js:label, nottitletimeattributedone | active | pending | failed(unknown values fall back topending), replacing the incorrecttodo/doing/blocked/skipped<agent-timeline>documented withlabel(defaultTimeline)<agent-action-list>/<agent-action>(previously undocumented): list attrslabel,layout(table/kanban/priority),group-by(status/priority),filter-status,filter-priority,show-done; item attrsowner,due,priority(high→P0,normal→P1,low→P2),status(open/in-progress/blocked/done). Noted that the item's visible label comes from body text and that filters/group-by apply to the table layout.<agent-proceed>(previously undocumented):label(defaultProceed →),allow-empty; the document-levelagent-isles:selectlistener; the composedagent-isles:proceedevent carrying{ type, selected, text }; and the disabled-until-selected / processing states.docs/wiki/Component-Vocabulary.md.<agent-finding>is the only component that remains under "Planned" — verified it is not exported fromsrc/components/index.js.Verification
Documentation-only change. Every attribute table was written against the component source (
agent-copy-block.js,agent-tabs.js,agent-timeline.js,agent-action-list.js,agent-proceed.js) and cross-checked against real usage inexamples/demo.md. There is no automated test that validates this doc againstindex.js, so there is no build/test to exercise these edits.🤖 Generated with Claude Code
https://claude.ai/code/session_01RjhixerKDdj4Fg5NuqHwk4
Generated by Claude Code