Skip to content

fix(release): check the mac terminal host against the fork's signing team #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zpyoung merged 1 commit into from
Oct 19, 2026
Merged

fix(release): check the mac terminal host against the fork's signing team #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions config/electron-builder.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,14 @@ const macUsageDescriptions = {
NSBonjourServices: ['_http._tcp', '_https._tcp'],
...MACOS_FOLDER_USAGE_DESCRIPTIONS
}
// Developer ID team that signs every release-channel mac build.
const ORCA_MAC_TEAM_ID = '6CX3WHS9HZ'
/** The Developer ID team the fork's release credentials sign with; a release build must name one. */
function readReleaseMacTeamId() {
const teamId = process.env.APPLE_TEAM_ID?.trim()
if (!teamId) {
throw new Error('APPLE_TEAM_ID is required for a macOS release build.')
}
return teamId
}

/** @type {import('electron-builder').Configuration} */
module.exports = {
Expand Down Expand Up @@ -836,7 +842,7 @@ async function packageMacTerminalHost(appPath, context) {
appPath,
arch,
usageDescriptions: macUsageDescriptions,
expectedTeamId: isMacRelease ? ORCA_MAC_TEAM_ID : null
expectedTeamId: isMacRelease ? readReleaseMacTeamId() : null
})
}

Expand Down
Loading