Repository navigation
Conversation
…8934) * fix: open editor rename after context menu releases focus * refactor(editor): tighten rename focus-handoff comments and test setup Correct the rename-input focus comment that still credited the animation frame with outrunning menu teardown, clarify why the rename now runs from onCloseAutoFocus, and fold the repeated menu-close invocation in the tab tests into one helper.
…ablyai#18952) * fix: avoid starting browser helpers just to reset absent sessions * refactor(browser): tighten the session-reset skip guard and its tests Drop the platform and absolute-path guards: ownsSocketDirectory is already false on Windows and for inherited directories, and an Orca-derived directory is always absolute. Fold the empty-name and traversal checks into agent-browser's own session-name rule. Stop lstat state leaking between lifecycle tests, and pin the probed socket path so the skip test cannot pass on an unwired mock.
…lyai#18982) * fix: preserve overlays during terminal mounting and layout * fix(terminal): stop a dismissed overlay from blocking pane focus Overlay primitives animate out (data-[state=closed]:animate-out, up to 300ms on sheets), so a dismissed dialog stays mounted and painted well past the point it should stop owning focus. The rAF-deferred focus in activateTabAndFocusPane lands inside that window, so revealing an agent from the dashboard drawer or a menu left the terminal unfocused. Treat data-state="closed" as gone, matching the [data-state="open"] convention already used by AgentDashboardDrawer and useWorkspaceBoardPanel. Also revert unrelated comment churn on scheduleRevealRepaint and note the new focus consumer in the hasVisibleOverlay doc comment. * refactor(terminal): scope the dismissed-overlay rule to pane focus Gate the data-state="closed" exclusion behind an ignoreDismissed option that only focusPanePreservingOverlays passes, leaving Escape semantics for the four existing hasVisibleOverlay callers unchanged. The focus race this fixes is specific to deferred focus (activateTabAndFocusPane defers by one rAF, landing inside the overlay's exit animation). Escape is synchronous and does not need the rule: Radix's useEscapeKeydown is capture phase, so every Escape caller runs while data-state is still "open". Avoids any behavior change on the Settings Escape path, which unlike the other three callers is bubble phase on document with no ordering guarantee.
…#19006) * fix: preserve terminal command probes across control frames * refactor(terminal): make the command-probe output flag explicit Hoist the duplicated Output/OutputSpan predicate in the binary frame handler, and require carriesOutput on recordInbound so no future call site can silently disarm the command-response probe by omitting it. Rework the control-frame regression into a named table so the fit-override and driver-changed cases send valid event payloads instead of stubs that returned before dispatch.
…ablyai#18922) * fix: preserve paired host sessions during startup residue cleanup * refactor(persistence): tighten the paired-host retention pass Dedupe the owner-key -> repo-id extraction the retention and seeding passes both needed, and name the `runtime:*` check instead of repeating the parse three times. Reach the session walker directly by exporting `addWorkspaceSessionWorktreeOwners` rather than fabricating a `{ workspaceSession }` state slice to get at it. Correct the docstrings: `runtime:*` also covers a serving host's own partition, and the "authoritative removal" they promised has no product caller on a paired client today, so say what the exemption actually costs. Add a survived-load assertion to the explicit-removal test, which otherwise passed against the pre-fix sweep -- the partition was already empty before the removal ran. No behavior change beyond the docs and the test assertion.
…updates (stablyai#18961) * fix: preserve renderer browser publication during client-hosted page updates * refactor: drop the now-dead publicationEpoch selection argument applyBrowserSessionTabSelection took a publicationEpoch and wrote it over the epoch the spread snapshot already carried. Its only production caller now passes snapshot.publicationEpoch, so the parameter is a no-op whose only remaining power is to reintroduce the epoch rotation this PR fixes. Remove it, and collapse the repeated prototype-cast boilerplate in the new reconciliation test into one helper. No behavior change. * fix: keep reconcile from publishing a browser row twice The retention filter partitioned existing rows by placement kind, so its disjointness from the live build relied on a non-local invariant: that the page registry only ever stores client placements and that server tabs are empty while no offscreen backend exists. Drop ids the live build already published instead, so a duplicate row is impossible by construction rather than by coincidence. * fix: stop the browser reconcile republishing on a pure reordering headlessBrowserTabsUnchanged compares by array index, so rebuilding the live list renderer-first read an interleaved snapshot as changed and republished with a bumped version and rebuilt tab groups for no semantic change - the same churn this branch exists to remove. Key the live set by id and emit it in the order the snapshot already had. Keying also makes uniqueness unconditional rather than resting on the page registry only ever storing client placements.
…18995) * fix: settle remote terminal insertion in the calling client * refactor: share one anchor insertion path for local and remote terminals Extract the created-tab-after-anchor reorder that the local terminal IPC bridge already carried into insertUnifiedTabAfterAnchor, and settle the remote placement through it instead of a second copy. Also repairs two anchor-resolution gaps in the settlement: - keep an exact unified tab id (legacy leaf-keyed anchors, browser and editor tabs) instead of collapsing every anchor to a terminal parent, which could mint a `web-terminal-<browser tab>` id that matches nothing - fall back to the anchor's own group when the requested group was closed while the mirrored tab was still in flight
…ablyai#19022) * fix: preserve session publication during runtime terminal fallback * refactor(runtime): align fallback epoch comment and test preamble Match the file's `// Why:` comment convention on the inherited publication epoch, and drop a redundant duplicate mocks import in the lineage regression test while keeping the required side-effect order. No behavior change.
) * fix: avoid credit deadlock during large SSH PTY recovery * test: restore bounded SSH flood recovery coverage * test(relay): pin the recovery fence to the accepted checkpoint The oversized-tail cases asserted that the drain completes, but not that recoveryEndSu lands on the checkpoint, so passing the pre-rotation snapshot (which carries the old client's window and a stale creditedEndSu) fenced below the checkpoint and still passed. Assert the fence value, narrow boundedPtyRecoveryEnd to the three fields it reads, and cover the exact one-window boundary that separates a live drain from an ordinary fence.
* fix: recognize working WSL1 without a WSL2 kernel
* fix: recognize unsigned Windows missing-kernel status
* fix(wsl): fold the missing-kernel guest probe into wsl-availability
The separate wsl-missing-kernel-probe module failed three CI gates: it was
not in the web typecheck project (TS6307), it added a new direct wsl.exe
spawn outside wsl-runner, and its `catch { return false }` tripped the
probe-failure-semantics ratchet.
wsl-availability.ts already owns the answer and is already on the invocation
allowlist, so the probe lives there now. A guest probe that cannot spawn
keeps the real --status failure instead of minting a fresh negative, which
is what the ratchet exists to prevent -- and is the more correct semantics.
…p retirement (stablyai#19142) boundRecentlyRetiredAgentStatusPaneKeys always rebuilt the record, replacing its reference even when nothing changed; a probe counted 1,099 such writes across the store suite. Return the existing record when no key would be evicted and the additions are already its tail in the same relative order. Key-set equality is deliberately NOT enough: re-adding a key must move it to the tail because that LRU order decides which key the cap evicts next. Share the LRU bound with boundRecentlyClosedAgentStatusTabIds, which had the same always-rebuild shape.
…never touched (stablyai#19145) * perf(worktrees): stop worktree teardown replacing arrays and maps it never touched Removing a worktree fires three store writes through removed-worktree-renderer-teardown.ts, and each handed back a fresh reference even when it removed nothing: - remove-worktree-store-cleanup filtered openFiles unconditionally. stablyai#19058 gave the ~50 record maps in this file identity preservation and missed the one plain array; the sibling purge path already had the guard this copies. openFiles is selected whole by the editor panel, file explorer and git-status polling. - shutdownWorktreeBrowsers spread-then-deleted browserTabsByWorktree and activeBrowserTabIdByWorktree; both now go through omitRecordKeys. - markShutdownPending rebuilt suppressedPtyExitIds and pendingPtyShutdownIds even with no guard ids at all, which is the normal case when the panes already exited. It now returns early, and skips the suppressed map when every id is already true. Same contents, same keys removed; only the reference is reused when nothing changed. * fix(test): use AppState['openFiles'][number] instead of a nonexistent module The test imported OpenFile from shared/editor-types, which does not exist. Vitest passed because a type-only import is erased at runtime; CI typecheck caught it. I had run tsc before adding this file and never re-ran it. * refactor(terminals): reuse copyOnWriteRecord in markShutdownPending and pin its identity contract
…19000) * fix: release floating terminal WebGL contexts while closed * test: pin retention polarity through a real PaneManager Replace the prototype-surgery fake with a constructed PaneManager so the suspend path exercises real constructor state, and add the retain-branch case so an inverted default cannot pass silently. De-shadow `window` in the system-resume e2e main-process callback.
…18910) * fix: fence browser recovery to attach inventory placements * refactor: name the attach-inventory fence and make its test deterministic Extract the placement check into isPlacedAsObservedAtAttach so the recovery filter stays a flat list of named predicates, and document that omitting pagePlacementsAtAttach recovers against unfenced live state. Replace the 30-microtask drain in the post-attach regression with the handler's own completion: attach only settles after recovery returns, so awaiting the dispatch orders the assertions instead of guessing at a microtask count. Verified by forcing the fence open: both regressions fail (the post-attach one in 60ms on a retired placement) and the other 27 still pass. * test: settle the attach handler even when the regression fails early The barrier ran inline, so a waitFor timeout or the placement guard left the attach handler parked on a promise nothing awaited. Hoist it into settleAttach and call it from a finally as well; cleanup is guarded and the dispatch promise is already settled, so the second call is a no-op.
* test: exercise native Wayland Hangul in isolated CI session * test: wait for nested compositor socket before selecting IBus * test: align Wayland IBus discovery with GNOME environment filtering * test: assert Wayland launch and register native Hangul evidence
* test: wait for rendered tabs and handle busy close confirmation * test: wait for create-menu item click actionability * test: settle initial terminal focus before create-menu actions * test: capture menu focus events for Linux CI diagnosis * test: remove menu diagnostics after identifying deferred layout focus * test: check Markdown menu dismissal after editor readiness
* feat(minimax): endpoint selector, API key auth, weekly usage window (stablyai#14264) The MiniMax (MiniMax) Coding Plan usage fetch was hardcoded to the overseas platform (platform.minimax.io) and a single 5h session window, so users on the CN endpoint (www.minimaxi.com) got nothing. Three changes: - Add `minimaxEndpoint` (`overseas`|`cn`) and `minimaxApiKeyConfigured` settings fields with sensible defaults that preserve current behavior. The CN endpoint also accepts an API key (safeStorage-encrypted via a new `minimax-api-key-store.ts` + IPC pair) for users without a browser session cookie. Status-bar visibility now OR's both credential flags. - Cookie-jar origin now tracks the active endpoint. Previously cookies were stored under the overseas origin and silently dropped when the user picked CN — fixed by threading `endpointMode` through the request context, the manual cookie header path, and the cookie-jar clear. - Parse the weekly window in addition to the 5h session and surface both as per-window chips (`5h [bar] 10% wk [bar] 20%`). The status bar's compact section prefers the session window; the popover keeps the existing `Session` / `Weekly` labels. The MiniMax fetcher is split into three files (data / parse / main) to stay under the 300-line cap. i18n is scoped to the Settings-page text (en + zh only); the 5H/7D duration shorthands stay English across locales by project convention. Tests: 9 new/updated files; cookies + API key exercised end-to-end via the rate-limit service with the upstream-refactored test files (`service-minimax-usage.test.ts`, `web-preload-api-settings.test.ts`, `web-preload-api-agent-providers.test.ts`, `service-test-harness.ts`, and the runtime-home / reset-credit fixtures). Refs stablyai#14264 * Keep merge formatting scoped to MiniMax * Keep MiniMax credential status in rate-limit test fixtures * Use the China console origin for MiniMax request referer --------- Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
…the percent (stablyai#17936) mapWeeklyCredits treated an absent creditUsagePercent as a confirmed protobuf zero whenever the weekly period matched billing bounds, so unified-billing accounts whose credits view never reports the percent showed a confident 0% and short-circuited the monthly fallback (stablyai#15740). Those payloads emit onDemandUsed/prepaidBalance zeros, which disproves the "encoder drops zeros" premise. Resolution order is now: reported percent → monthly used/monthlyLimit pair as a monthly window → synthetic 0 only when the payload emits no usage scalars at all and the weekly period is confirmed → unavailable with an explicit reason the Accounts pane surfaces. Rebased onto current main from nwparker/grok-usage-percent-fallback (stablyai#15878). Fixes stablyai#15740 Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
* test: enable CI WebGL and route GPU-dependent regressions * test: retain headful atlas cases in terminal rendering goldens * test: reuse golden command in project coverage assertions
…#8129) (stablyai#18554) * feat(cloud): add the mobile push gateway and its contract package (stablyai#8129) A small open-source service that holds the APNs key and FCM credentials and sends background push to paired phones on the desktop's behalf. Hosts authenticate with a box challenge and HMAC proof on their pairing key, the same shape the relay uses, so signed-in and accountless desktops share one path. Tokens are stored; alert text is held only for the coalescing window. The contract doc in docs/reference is the source of truth for every wire shape. The interop test runs the real desktop answerer against a real gateway-issued challenge so transcript drift fails in CI. * feat(push): register phones and send background push from the desktop (stablyai#8129) Adds the notifications.remote-push.v1 capability, the registerPush and unregisterPush RPCs on the mobile allowlist, a gateway client with a cached session and 401 re-auth, a durable unregister outbox, and a dispatcher that offers every mobile notification to the gateway after the socket fan-out. The dispatcher is fire-and-forget with one retry and drops registrations the gateway reports dead. Puts agentState on the mobile frame and fixes the stablyai#4375 wording so a working agent is never announced as finished. The relay host-proof code moves onto a shared envelope module with no behaviour change. * feat(mobile): background push registration, receive, and settings (stablyai#8129) Fetches the native APNs or FCM token, registers it with every paired host that advertises the capability, and re-registers on token change. Foreground pushes are suppressed inside handleNotification against the same seen set the socket path uses, so nothing shows twice. Taps route by host fingerprint. One Background notifications switch, off by default, with the disclaimer and needs-input / finished sub-switches; hidden until a paired desktop is new enough. Adds google-services.json and the expo-notifications plugin. * chore(cloud): Terraform and deploy workflow for the push gateway (stablyai#8129) Declares the Cloud Run service, runtime account, secrets, and orca_push database behind push_gateway_enabled, true only in production. The deploy workflow is gated like the relay's, deploys with no traffic, probes /ready and a validate-only FCM send, then shifts traffic. It runs as the shared production deploy account because the Cloud SQL rollout lease grant is foundation-owned; its extra authority is three bindings on the push service. docs/push-gateway.md carries the import commands for the resources created by hand and the APNs key rotation procedure. * docs: describe background notifications on the phone (stablyai#8129) * docs: check in the mobile push contract (stablyai#8129) Seven committed files cite it as the source of truth for every wire shape; docs/reference is allowlisted per file, so add the entry. * test(push): replay one checked-in host-proof vector on both sides (stablyai#8129) Cloud Verify installs only the cloud workspace, so the gateway suite cannot import the desktop answerer. Replace the cross-workspace import with a fixed challenge vector generated from the contract package; the gateway fixture and the desktop answerer each replay it and must produce the same HMAC. A transcript drift on either side now fails in that side's own suite. * fix(cloud): open the push gateway with invoker_iam_disabled, not an allUsers binding (stablyai#8129) The production domain-restricted-sharing policy rejects an allUsers run.invoker member, which the runbook anticipated. Opt the service out of invoker IAM the way the relay director already does; the host proof is the authentication either way. * docs(cloud): the push.onorca.dev record exists and is hand-managed (stablyai#8129) * fix(push): close review findings in the gateway (stablyai#8129) - Quota reservation takes a per-host advisory lock; READ COMMITTED admitted a whole burst past the cap (80/80 without, 60/80 with, against Postgres 16). - Challenge issuance no longer writes push_hosts; the row lands on proof verification. Stale hosts prune after 30 days. Per-IP token bucket on the two unauthenticated routes. - Streaming body limit via hono bodyLimit; a chunked body bypassed the Content-Length check. - registrationIds deduped in the schema; per-host device cap of 64; list bounded to its schema. - Gateway-side challenge TTL is the specified 10 s, not 40 s. - APNs stream settles on close as well as end/error. * fix(push): close review findings in the desktop client (stablyai#8129) - A gateway registration the registry cannot persist is enqueued for delete instead of leaking a live token. - Unregister outbox re-reads pending per pass, honours enqueues during a drain, and retries with backoff instead of waiting for the next launch. - Dispatcher batches registrations by 20 rather than starving the rest. - 401 compare-and-clear; a 401 after re-auth is unreachable; refused handshakes and 429s are cached briefly instead of re-handshaking per event. - Service is stopped on quit. * fix(mobile): close review findings in push registration and receive (stablyai#8129) - Consent generation guards a register that finishes after the switch went off; the host is re-queued for unregister instead of recorded live. - Foreground pushes seed the watermark before adopting the epoch, so a push on a never-connected session cannot wipe a valid watermark. - aps-environment follows the build via app.config.js; the iOS release workflow sets it to production. A bare plugin entry wrote development. - Pushes the OS showed while closed are marked seen before catch-up replay. - Token null result is not cached; failed capability probes are retried and never block an unregister; coalesced summaries are shown but not marked. - Unresolvable fingerprint routes nowhere and is suppressed in foreground. - Android channel ensured at boot; capability hook diffs clients by identity. * fix(cloud): harden the push deploy workflow and size the gateway to the budget (stablyai#8129) - Roll traffic back on a failed post-shift check; delete a candidate that never took traffic; retry the origin probe and the FCM probe. - Assert Terraform-owned scaling instead of mutating it from the workflow. - Build before taking the Cloud SQL rollout lease. - Declare the database pool in Terraform (2 per instance, max 2 instances) and add the gateway to the connection budget; the previous default put the shared instance 65 connections over its ceiling. - State plainly that the shared deploy identity's relay authority is inherited. * fix(push): read the runtime from shared state at push startup (stablyai#8129) Threading the runtime through launchDesktopMode put the launch module one line over the 300-line lint budget after the rebase. * fix(push): key the unauthenticated rate limit on the hop Cloud Run wrote (stablyai#8129) Cloud Run appends the connecting peer to x-forwarded-for; the limiter read the left-most value, which the caller controls, so a forged first hop earned a fresh bucket per request. * fix(push): close the final security review findings in the gateway and infra (stablyai#8129) - app.onError logs only the error name and answers a bare 500; hono's default handler printed the whole error, and a pg error carries the row in detail - a second per-IP bucket (240/min) runs ahead of the bearer lookup on every authenticated route, so forged bearers cannot spend the two-connection pool - one live session per host: minting deletes the host's earlier row - device-less hosts are pruned after 1 h, not 30 d; any keypair mints one free - notificationId is printable ASCII, since it becomes the APNs collapse header - the impersonated FCM probe token is masked in the workflow log - prevent_destroy on the Apple secrets and the orca_push database * fix(push): close the final security review findings in the desktop client (stablyai#8129) - fetch never follows a redirect: a 307 would replay the host proof and the phone's token to whatever origin the redirect named - registerPush params are strict and the paired identity is spread last - a per-device bucket (10/min) bounds a phone looping registerPush, which costs a gateway write and a synchronous registry write each time * fix(mobile): close the final security review findings in push receive (stablyai#8129) - a push with no epoch can no longer claim a seq-derived dedup key, in the foreground or from the tray; a forged seq:N could otherwise swallow the real bell at that seq - a provider-delivered push with no host catalog, or no fingerprint at all, stays unrouted instead of falling back to the hostId its raw data carries * docs(push): record the ip buckets, session and host retention, and the token-ownership limit (stablyai#8129) * fix(push): apply the schema on an untimed pool and retry statement-timeout aborts (stablyai#8129) Ports the relay's stablyai#18722 pattern to the gateway: DDL runs on a one-connection pool with statement_timeout 0 that is closed before the serving pool opens, and SQLSTATE 57014 joins the bounded transaction retry path. * fix: harden mobile push delivery and deployment recovery * feat: align mobile notification preferences with desktop delivery * fix: accept variable-length APNs device tokens * fix: deduplicate native APNs and background socket notifications
…19392) * perf(workspaces): reuse unchanged heartbeat status projections * perf(workspaces): skip unchanged title-sync session collections * test(workspaces): cover constant-size key swaps in status projection reuse Also point the title-input gate at a tracked source file; the previous motivatingLink referenced an untracked .agents skill path.
…yai#19494) * perf: probe requested pane keys instead of enumerating records * perf(agent-status): drop the requested-key array from pane removal Probing the pane keys still beat enumerating the record, but materializing the requested set allocated on every call including the common no-match path, where a dozen records are swept per retirement. Copy lazily on first match instead, and cover the set-disagreement and prototype-key cases. --------- Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local> Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
…ns (stablyai#19495) * perf: resolve current-workspace document addresses before catalog scans * test(browser): lock current-workspace precedence in doc address resolution --------- Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local> Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
…yai#19498) * perf: materialize only the requested recent plugin audit lines * test(plugins): prove the recent audit window matches the full-split selection --------- Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local> Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
…9720) The two flakiest tests on main both guessed at a duration instead of waiting for the condition. - windows-pty-job.win32.test.ts assumed job teardown finished in 1.5s; under load on a Windows runner it does not. Poll isAlive up to 30s instead -- the assertion is unchanged, so a real leak still fails. - structured-agent-session-claude-options-round-trip.test.ts relied on vi.waitFor's 1s default for a two-hop handoff; give it 10s. Both are test-only and strictly widen an existing wait.
…#19508) * perf: stop merging OS-opened files at the pending queue cap * fix(os-open): report markdown opens dropped at the pending queue cap --------- Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local> Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
…blyai#19393) * perf(terminal): skip plain text between partial escape sequences * perf(terminal): take the ESC at hand before searching for one The unconditional ground-state indexOf regressed dense back-to-back SGR/CSI streams, where the code unit at the cursor is already the ESC and the search pays call plus SIMD setup to find it in place. Check the current unit first and fall back to the native search otherwise. 0.9 MiB dense SGR/CSI medians: 2.04 ms before this PR, 2.56 ms with the unconditional search, 1.92 ms with the hybrid. Sparse colored logs and plain text keep the full search win (0.36 / 0.016 ms vs 1.54 / 1.41 ms baseline). Differential over the full VT alphabet with lone and split surrogates matched 388,416 cases against both prior implementations with zero mismatches; the ground-scan work budget now records 16 inspected code units and 2 native searches.
…rols (stablyai#19396) * perf(terminal): release oversized backing strings behind pending controls * test(terminal): record reproducible pending-storage gate evidence * perf(terminal): own retained control fragments with a fast copy primitive The pending-control ownership landed with a charCodeAt block copier (10 us at 4 Ki, 170 us at 64 Ki), so it needed a "copy only when discarded output dominates the tail" gate to stay affordable. That gate was the whole cost problem: on adversarial streams it fires every chunk and pays the slow copy (+45% on 16 Ki ANSI chunks, +81..111% on 194 Ki status chunks), and it also skipped ownership on fragments too small to be sliced strings anyway. ownRetainedString replaces it with a Buffer utf16le round trip (0.57 us at 4 Ki, 21.9 us at 64 Ki) and returns anything below V8's SlicedString kMinLength unchanged. Buffer is absent in the renderer and on mobile, so the copier is resolved once behind a lone-surrogate round-trip self-check and falls back to the block copier. With a ~1 us copy the gate is unnecessary: ownership is now unconditional at all three retention sites and the adversarial cases land within noise of the un-owned parsers. The three forced-GC threshold fixtures are replaced by one forced-GC test for the primitive plus deterministic spy assertions that each site routes its retained value through ownRetainedString. All fidelity and differential coverage is kept. * fix(terminal): escape the NUL in the round-trip probe A raw NUL byte in the source made git treat the file as binary, so its diffs and blame were unreadable. Escapes are equivalent at runtime.
…ai#19400) * perf(terminal): skip ordinary output in preview control scans * test(terminal): cover scan resumption after parsed controls
…nks (stablyai#19528) Every row in the 2000-row retained tail is sliced from the PTY chunk it arrived in, so a spinner workload — CR-redraw frames, exactly what Claude Code and Codex emit — makes a ~5 KB tail pin one whole chunk per row. Measured on 400 x 64 Ki-char chunks: a 5,090-char tail retained 37.5 MB. At 16 Ki x 1600 it was 46.9 MB. Own the two values the plain tail path actually retains, newlyCompletedLines and the partial line, at the point they enter the tail: 37.5 MB -> 0.18 MB and 46.9 MB -> 0.09 MB, with per-chunk cost unchanged within noise. The transcript keeps the same row objects, so it is covered transitively. The multiline redraw builder never slices normalizedChunk — it writes rows character by character — so only its partial line, which is re-sliced from its own row on every frame, needs owning. Owning its rows as well measured no retention gain and cost CPU on fullscreen TUI floods. Also own the wait-blocked keywordCarry: 31 characters that pinned a full lowercased copy of the chunk, per PTY. Follow-up to stablyai#19396, which introduced ownRetainedString for the much smaller pending-control fragments.
…lyai#19497) * perf: check tunnel queue capacity before copying frame payloads * fix(browser-tunnel): derive writer admission size from the frame encoder Shares one encoded-length helper so the pre-encode capacity check cannot drift from what encoding allocates, and covers the exact byte-cap boundary. --------- Co-authored-by: m4air <m4air@m4airs-MacBook-Air.local> Co-authored-by: Neil <4138956+nwparker@users.noreply.github.com>
…#19753) * fix(native-chat): activate worktree before chat session * test: update native chat activation census
The linux-arm64 release build failed packaging, and retried three times:
[verify-linux-glibc-floor] 1 bundled native binary is built for the
wrong architecture (target arm64):
resources/node_modules/@parcel/watcher-linux-x64-glibc/watcher.node
is x64, expected arm64 (from its own path)
`afterPack` ran `verifyLinuxGlibcFloor` at its top, before
`prunePackagedRuntimeNodeModules`. A cross-build intentionally installs
every optional native variant, so at that point the arm64 slice still
carries the x64 `@parcel/watcher` package that the prune exists to drop.
The check was reading a file that was never going to ship.
Move the floor check below the prune so it inspects the binaries actually
packed. Same ordering as 35f1b0e on the v1.4.197 release branch, which
shipped green and was never merged back to main.
(cherry picked from commit 6400598)
(cherry picked from commit a883e17)
The macOS, Windows, and both Linux release builds all failed on "Verify
telemetry constants present in app.asar", blocking publish-release:
::error::BUILD_IDENTITY constant missing or unexpected value in
dist/mac-arm64/Orca.app/Contents/Resources/app.asar
The verifier printed no context sample, because the string
`BUILD_IDENTITY` does not occur anywhere in the shipped bundle at all.
stablyai#17527 added `minify: 'oxc'` to the main bundle, so oxc renames the
module-local `const BUILD_IDENTITY` to a short identifier.
`BUILD_IDENTITY_RE` keys off the literal name and therefore cannot match a
production bundle. `MINIFIED_TELEMETRY_RE` matches the adjacent injected
identity/key pair instead, which survives renaming.
stablyai#11019 created these patterns without that fallback, and its own comment
predicted this exact failure if minification were ever enabled on the main
bundle. The fallback was written on the v1.4.197 release branch in
35f1b0e and never merged back to main, so main has never been able to
verify a minified bundle.
Verified against a real local bundle built with the release env vars
(ORCA_BUILD_IDENTITY=stable, ORCA_POSTHOG_WRITE_KEY=phc_...): the bundle
does not contain "BUILD_IDENTITY"; both the narrowed and the widened
BUILD_IDENTITY_RE fail; MINIFIED_TELEMETRY_RE matches and recovers
identity=stable plus the write key.
(cherry picked from commit 39c3e44)
(cherry picked from commit d0bbe44)
The Windows skill-sharing release gate — which blocks publish-release — failed on this test, wedging the 1.4.198 cut. The implementation is correct; the assertion was not. `findSkillFiles` pushes results in `readdir` order and dedupes visited directories by realpath, so of the 32 junctions pointing at one target exactly one survives. The assertion hardcoded both the array order and which link won. `readdir` order is filesystem-dependent: APFS and ext4 return SKILL.md first, while NTFS enumerates its filename index alphabetically on the uppercased name, where "LINK00" sorts before "SKILL.MD" (L=0x4C < S=0x53). Windows therefore returned the same two paths in the opposite order. Assert the contract instead: the real file is present, exactly one link-routed path survives dedup, and nothing else does. (cherry picked from commit 9a832e9) (cherry picked from commit 505b85c)
…tablyai#19927) * fix(browser): restore the Chrome-shaped browser identity (STA-7147) stablyai#18749 replaced every browser partition's Chrome-shaped UA with Electron's stock one, so since v1.4.198 the embedded browser announces itself on every non-Google host as: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Orca/1.4.198 Chrome/150.0.7871.224 Electron/43.4.1 Safari/537.36 No browser sends that. Sites that re-check the identity holding a session reject it: users report being signed out of x.com, LinkedIn and "most websites," and at least one was signed out of LinkedIn in their own Chrome and met LinkedIn's "suspicious activity" SMS check -- server-side revocation, which reaches beyond our app. The repo already documented the mechanism in browser-google-auth-ua.ts: copied-in cookies "sent under a UA that doesn't match a real first-party browser get flagged by anti-fraud." That is why the Google auth-host switch exists; stablyai#18749 kept it for accounts.google.com and handed every other host an Electron identity. Restore the pre-stablyai#18749 session identity: strip the Electron and app tokens, and rewrite sec-ch-ua to match. Nothing in the cookie-import write path changed -- it never did; cookies were always written correctly and servers were refusing them. Deliberately KEPT from stablyai#18749, all independent of the UA: - anti-detection.ts stays deleted. Its premises were measured false on Electron 43 and its overrides are themselves published bot signatures. - No Runtime.enable into cross-origin iframes (the documented Cloudflare CDP tell). - No unconditional CDP debugger attach on every browsing guest. Known tradeoff, measured: this re-opens stablyai#13822. On the unmerged predecessor branch brennan/sta-3905-cloudflare-ua, commit 9f0a477 recorded the stock UA clearing dash.cloudflare.com 5/5 while every rewritten variant failed 12/12, and noted that adding client hints does not rescue it. So Cloudflare-gated sites will show verification failures again until a coherent-identity fix lands. That is a bounded, in-app annoyance; session revocation damages users' real accounts. A CDP Emulation.setUserAgentOverride with full userAgentMetadata -- which drives navigator.userAgentData as well as the headers, and was never tested -- is the candidate that could satisfy both, and is being measured separately. Tests: the real-Electron wire-identity test now asserts the stripped identity on ordinary hosts and Firefox on Google auth hosts. Ablation-verified: neutering cleanElectronUserAgent turns it red on the Electron-token assertion. Its fixture also gained an app name -- without one the raw UA carried no app token, so the Orca/x.y.z half of the cleaner was never exercised. * fix(browser): finish the identity revert in the files CI caught browser-session-registry.persistence.test.ts still asserted stablyai#18749's behaviour ("keeps the stock UA", "keeps the engine UA"), so the shipped code and its test disagreed. Caught by CI shard 4/8, not locally: I reverted four test files and went to typecheck without re-running the browser suite. Also restores the accurate wording that stablyai#18749 generalised away, now that the behaviour it described is back: - browser-google-auth-ua.ts: names the Electron/Chrome-shaped UA again as what anti-fraud flags, which is the reason the auth-host switch exists at all. - docs/browser/profiles.mdx: documents the cleaned Chrome UA default and the --no-ua-spoof escape hatch, which is real again. - tests/tools/google-signin-ua-probe.cjs: comments name the live handler. Deliberately left at stablyai#18749's version, because those changes stay correct with anti-detection.ts deleted: - browser-manager-viewport.ts: its comment no longer cites the retired addScriptToEvaluateOnNewDocument injection. - browser-webauthn-profile-delete.test.ts: its added webRequest mock is REQUIRED by the restored setupClientHintsOverride, so reverting it would break the test. * fix(browser): keep restored UA hints browser-owned --------- Co-authored-by: Merge Sim <sim@local> (cherry picked from commit fb85f88)
…auto-sync-fork-with-upstream-stablyai-orca-ru-20260911T1400 # Conflicts: # src/renderer/src/components/native-chat/NativeChatComposerField.tsx # src/renderer/src/components/native-chat/native-chat-composer-composition.test.tsx # src/renderer/src/components/native-chat/native-chat-draft-cache.ts
Resolve every differing path against config/fork-ownership.json, then repair what -X ours defended and replay what the release moved under the fork. checkout.txt (2382) reset unclaimed upstream files to the tag; remove.txt (133) honoured the fork's deletions; ours.txt (92) restored fork exceptions, then three-way merged the 17 the release also touched so package.json takes upstream's dependency and script changes, reliability-gates takes its 1090 new rows, and the Electron runtime contract takes the new golden-project assertions. Eleven fork edits to upstream-owned files carried no declaration, so the reset reverted them: the terminal dock's mobile-session projections and ack path, the session-handoff and session-info preload registrations, the native-chat width and relay import swaps, and the tool-category glyphs. All eleven are restored and now declared as seams, with residual budgets, so the next sync keeps them. v1.4.200 landed the fork's composer file-drop scoping upstream as `scopeKey`, so the four pending-upstream exceptions and their ledger section are gone and the fork's composer field publishes data-composer-scope-key. The release also added a contenteditable prompt editor whose modules the fork deleted; those eight deletions are withdrawn so upstream's own new files compile, while the fork's composer keeps its own field and caches. Seam repairs: the picker now carries both upstream's session-reported skill authority and the fork's plugin attribution; the composer adopts upstream's structured-send hook instead of its stale inline copy; the AI Vault handoff seam re-homes into the extracted AiVaultVirtualRow; the SSH ack path reads the new three-outcome settlement union; and the window-wake effect gets back the isChatViewMode dependency -X ours dropped.
…k-with-upstream-stablyai-orca-ru-20260911T1400 # Conflicts: # config/fork-ownership.json # src/renderer/src/store/slices/worktrees/session/set-active-folder-workspace.ts
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR absorbs upstream v1.4.200 while preserving fork-owned behavior through ownership, seam, and tier-2 reconciliation.
Changes:
- Reconciles upstream runtime, structured-session, browser, and agent updates.
- Adds shared sorting, session identity, resume fingerprinting, and projection utilities.
- Updates E2E coverage, headful CI launch behavior, and benchmark fixtures.
File summaries
| File | Description |
|---|---|
| tests/tools/relay-bench/.gitignore | Updated as part of this pull request. |
| tests/tools/benchmarks/spinner-rendering/fixture.css | Updated as part of this pull request. |
| tests/e2e/terminal-tab-switch-visual-restore.spec.ts | Updated as part of this pull request. |
| tests/e2e/terminal-hangul-terminating-digit-native.spec.ts | Updated as part of this pull request. |
| tests/e2e/terminal-foreground-redraw-freeze.spec.ts | Updated as part of this pull request. |
| tests/e2e/terminal-document-visibility-webgl-recovery.spec.ts | Updated as part of this pull request. |
| tests/e2e/ssh-docker-transport-drop-recovery.spec.ts | Updated as part of this pull request. |
| tests/e2e/pr11346-selected-runtime-add.spec.ts | Updated as part of this pull request. |
| tests/e2e/paired-browser-creation-reconciliation-failure.spec.ts | Updated as part of this pull request. |
| tests/e2e/new-workspace-create-more.spec.ts | Updated as part of this pull request. |
| tests/e2e/helpers/electron-launch-args.ts | Updated as part of this pull request. |
| tests/e2e/completed-worker-retirement-resume.spec.ts | Updated as part of this pull request. |
| src/shared/workspace-session-sleeping-agents.ts | Updated as part of this pull request. |
| src/shared/updated-at-order.ts | Updated as part of this pull request. |
| src/shared/tui-agent-config.ts | Updated as part of this pull request. |
| src/shared/synthetic-agent-title.ts | Updated as part of this pull request. |
| src/shared/structured-session-marker.ts | Updated as part of this pull request. |
| src/shared/structured-agent-session-mutation.ts | Updated as part of this pull request. |
| src/shared/structured-agent-session-message-projection.ts | Updated as part of this pull request. |
| src/shared/structured-agent-session-coalescer.ts | Updated as part of this pull request. |
| src/shared/runtime-types.ts | Updated as part of this pull request. |
| src/shared/runtime-session-contracts.ts | Updated as part of this pull request. |
| src/shared/runtime-mobile-session-tab-contracts.ts | Updated as part of this pull request. |
| src/shared/remote-runtime-client-capabilities.ts | Updated as part of this pull request. |
| src/shared/rate-limit-types.ts | Updated as part of this pull request. |
| src/shared/rate-limit-types.test.ts | Updated as part of this pull request. |
| src/shared/pty-listed-session.ts | Updated as part of this pull request. |
| src/shared/persisted-ui-state-types.ts | Updated as part of this pull request. |
| src/shared/pane-agent-identity-inventory.test.ts | Updated as part of this pull request. |
| src/shared/pairing-local-ui-fields.ts | Updated as part of this pull request. |
| src/shared/pairing-local-ui-fields.test.ts | Updated as part of this pull request. |
| src/shared/osc-title-scan-tail.ts | Updated as part of this pull request. |
| src/shared/orchestration-retry-request-id.ts | Updated as part of this pull request. |
| src/shared/native-chat-tool-activity.ts | Updated as part of this pull request. |
| src/shared/growing-byte-buffer.ts | Updated as part of this pull request. |
| src/shared/git-history.test.ts | Updated as part of this pull request. |
| src/shared/git-history-types.ts | Updated as part of this pull request. |
| src/shared/foreground-process-selection.test.ts | Updated as part of this pull request. |
| src/shared/ephemeral-vm-runtime-rollback-projection.ts | Updated as part of this pull request. |
| src/shared/default-global-settings.ts | Updated as part of this pull request. |
| src/shared/constants.ts | Updated as part of this pull request. |
| src/shared/constants.test.ts | Updated as part of this pull request. |
| src/shared/cli-argument-boundary.ts | Updated as part of this pull request. |
| src/shared/child-process/child-process-import-boundary.test.ts | Updated as part of this pull request. |
| src/shared/child-process/fixtures/child-process-import-allowlist.txt | Updated as part of this pull request. |
| src/shared/automation-run-retention.ts | Updated as part of this pull request. |
| src/shared/agent-status-freshness.ts | Updated as part of this pull request. |
| src/shared/agent-session-resume.ts | Updated as part of this pull request. |
| src/shared/agent-session-question-answer.ts | Updated as part of this pull request. |
| src/shared/agent-session-chat-label.ts | Updated as part of this pull request. |
| src/renderer/src/web/web-runtime-client.test.ts | Updated as part of this pull request. |
| src/renderer/src/web/web-preload-api-ui.test.ts | Updated as part of this pull request. |
| src/renderer/src/web/preload-api/web-preference-normalization.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/ui/ui-slice-preference-actions.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/ui/ui-slice-hydration-actions.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/ui/ui-slice-contract-preferences.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/tabs/tabs-reconciliation-batch.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/browser-page-records.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/agent-status-slice-contract.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/agent-status-provider-session-actions.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/agent-status-orchestration-context.ts | Updated as part of this pull request. |
| src/renderer/src/store/slices/agent-status-contract.ts | Updated as part of this pull request. |
| src/renderer/src/runtime/web-session-tabs-sync/load-initial.ts | Updated as part of this pull request. |
| src/renderer/src/runtime/web-session-tabs-sync/global-session-inventory-event.ts | Updated as part of this pull request. |
| src/renderer/src/runtime/web-session-tabs-sync/global-session-events.ts | Updated as part of this pull request. |
| src/renderer/src/runtime/web-session-tabs-sync/active-session-subscription.ts | Updated as part of this pull request. |
| src/renderer/src/runtime/sync-runtime-graph/graph-publication.ts | Updated as part of this pull request. |
| src/renderer/src/runtime/sync-runtime-graph-parked-leaf.test.ts | Updated as part of this pull request. |
| src/renderer/src/runtime/remote-runtime-terminal-response-controller.ts | Updated as part of this pull request. |
| src/renderer/src/lib/worktree-creation-structured-session.ts | Updated as part of this pull request. |
| src/renderer/src/lib/worktree-activation-surface-caller-wiring.test.ts | Updated as part of this pull request. |
| src/renderer/src/lib/worktree-activation-store-contract.ts | Updated as part of this pull request. |
| src/renderer/src/lib/workspace-tab-palette-content-type.ts | Updated as part of this pull request. |
| src/renderer/src/lib/windows-terminal-capabilities.ts | Updated as part of this pull request. |
| src/renderer/src/lib/web-client-location.ts | Updated as part of this pull request. |
| src/renderer/src/lib/visible-overlay.test.ts | Updated as part of this pull request. |
| src/renderer/src/lib/structured-agent-session-launch-refusal-fallback.test.ts | Updated as part of this pull request. |
| src/renderer/src/lib/simulator-palette-search.test.ts | Updated as part of this pull request. |
| src/renderer/src/lib/resume-sleeping-agent-session.ts | Updated as part of this pull request. |
| src/renderer/src/lib/pane-manager/pane-overlay-focus.ts | Updated as part of this pull request. |
| src/renderer/src/lib/pane-manager/pane-manager-types.ts | Updated as part of this pull request. |
| src/renderer/src/lib/pane-manager/pane-manager-pane-creation.ts | Updated as part of this pull request. |
| src/renderer/src/lib/palette-match/palette-assignment-inspection.ts | Updated as part of this pull request. |
| src/renderer/src/lib/native-chat-initial-view-mode.ts | Updated as part of this pull request. |
| src/renderer/src/lib/live-resume-anchor-record.ts | Updated as part of this pull request. |
| src/renderer/src/lib/ai-vault-tab-title-sync-inputs.ts | Updated as part of this pull request. |
| src/renderer/src/hooks/use-palette-search-evaluation-context.ts | Updated as part of this pull request. |
| src/renderer/src/hooks/ipc-events/browser-request-ipc-bridge.ts | Updated as part of this pull request. |
| src/renderer/src/hooks/composer-state/composer-drop-listener.ts | Updated as part of this pull request. |
| src/renderer/src/components/worktree-jump-palette-worktree-row.tsx | Updated as part of this pull request. |
| src/renderer/src/components/worktree-jump-palette-surface.tsx | Updated as part of this pull request. |
| src/renderer/src/components/use-task-page-repo-selection.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/use-terminal-pane-projection.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/use-terminal-pane-global-listeners.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/TerminalPaneOverlayLayer.react185.test.tsx | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/terminal-pane-recovery.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/terminal-appearance.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/replay-guard.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/pty-connection/sleeping-record-access.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/pty-connection/cold-restore-resume-startup.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/pane-helpers.ts | Updated as part of this pull request. |
| src/renderer/src/components/terminal-pane/pane-helpers.test.ts | Updated as part of this pull request. |
| src/renderer/src/components/task-page-github-status-actions.ts | Updated as part of this pull request. |
| src/renderer/src/components/tab-bar/TabBarCreateEntryRow.tsx | Updated as part of this pull request. |
| src/renderer/src/components/tab-bar/TabBarCreateEntry.tsx | Updated as part of this pull request. |
| src/renderer/src/components/tab-bar/tab-bar-item-model.ts | Updated as part of this pull request. |
| src/renderer/src/components/tab-bar/EditorFileTab.tsx | Updated as part of this pull request. |
| src/renderer/src/components/status-bar/use-status-bar-controller.ts | Updated as part of this pull request. |
| src/renderer/src/components/status-bar/CodexSwitcherMenu.tsx | Updated as part of this pull request. |
| src/renderer/src/components/sidebar/WorktreeList.tsx | Updated as part of this pull request. |
| src/renderer/src/components/settings/TerminalRenderingSection.tsx | Updated as part of this pull request. |
| src/renderer/src/components/settings/setting-labels.ts | Updated as part of this pull request. |
| src/renderer/src/components/settings/MobileSettingsPane.tsx | Updated as part of this pull request. |
| src/renderer/src/components/settings/BrowserTerminalLinkActionsSetting.tsx | Updated as part of this pull request. |
| src/renderer/src/components/settings/browser-search.ts | Updated as part of this pull request. |
| src/renderer/src/components/settings/browser-search.test.ts | Updated as part of this pull request. |
| src/renderer/src/components/settings/browser-link-routing-copy.ts | Updated as part of this pull request. |
| src/renderer/src/components/settings/accounts-search.test.ts | Updated as part of this pull request. |
| src/renderer/src/components/settings/accounts-pane-types.ts | Updated as part of this pull request. |
| src/renderer/src/components/right-sidebar/source-control/listing/branch-section.tsx | Updated as part of this pull request. |
| src/renderer/src/components/right-sidebar/ai-vault-session-resume.test.ts | Updated as part of this pull request. |
| src/renderer/src/components/new-workspace/ProjectCombobox.dialog-handoff.test.tsx | Updated as part of this pull request. |
| src/renderer/src/components/native-chat/use-native-chat-typed-insertion.ts | Updated as part of this pull request. |
| src/renderer/src/components/native-chat/use-native-chat-dictation-actions.ts | Updated as part of this pull request. |
| src/renderer/src/components/native-chat/use-native-chat-composer-app-menu-selection.test.tsx | Updated as part of this pull request. |
| src/renderer/src/components/native-chat/structured-agent-session-message-projection.ts | Updated as part of this pull request. |
| src/renderer/src/components/native-chat/native-chat-tool-summary.ts | Updated as part of this pull request. |
| src/renderer/src/components/native-chat/native-chat-session-option-settings-write.ts | Updated as part of this pull request. |
| src/renderer/src/components/native-chat/native-chat-prompt-editor.test-support.ts | Updated as part of this pull request. |
| src/renderer/src/components/native-chat/native-chat-composer-input.ts | Updated as part of this pull request. |
| src/renderer/src/components/mobile/mobile-platform-copy.ts | Updated as part of this pull request. |
| src/renderer/src/components/Landing.tsx | Updated as part of this pull request. |
| src/renderer/src/components/hover-reveal-touch-action-visibility.test.ts | Updated as part of this pull request. |
| src/renderer/src/components/dashboard-popout/preview-terminal-options.ts | Updated as part of this pull request. |
| src/renderer/src/components/cmd-j/palette-section-render-cap.test.ts | Updated as part of this pull request. |
| src/renderer/src/components/browser-pane/workspace-doc/workspace-doc-page-pane.tsx | Updated as part of this pull request. |
| src/renderer/src/components/browser-pane/host-guest/browser-page-webview-guest-session.ts | Updated as part of this pull request. |
| src/renderer/src/components/activity/ActivityPrototypePage.thread-grouping.test.ts | Updated as part of this pull request. |
| src/renderer/src/components/activity/activity-thread-list-toolbar.tsx | Updated as part of this pull request. |
| src/renderer/src/components/activity/activity-prototype-page-exports.ts | Updated as part of this pull request. |
| src/renderer/src/components/activity/activity-event-builder.bounded-history.test.ts | Updated as part of this pull request. |
| src/preload/preload-runtime-support.ts | Updated as part of this pull request. |
| src/main/windows/windows-process-tree-command-line-patch.test.ts | Updated as part of this pull request. |
| src/main/warp-themes/directory-entry-order.ts | Updated as part of this pull request. |
| src/main/startup/main-process-state.ts | Updated as part of this pull request. |
| src/main/ssh/ssh-remote-orca-cli.ts | Updated as part of this pull request. |
| src/main/ssh/ssh-relay-pty-master-cloexec-install.test.ts | Updated as part of this pull request. |
| src/main/ssh/ssh-relay-node-pty-spawn-repair.test.ts | Updated as part of this pull request. |
| src/main/ssh/ssh-relay-native-deps-cache-deploy.test.ts | Updated as part of this pull request. |
| src/main/ssh/ssh-relay-deploy.test.ts | Updated as part of this pull request. |
| src/main/ssh/ssh-channel-multiplexer.ts | Updated as part of this pull request. |
| src/main/ssh/ssh-channel-multiplexer.test.ts | Updated as part of this pull request. |
| src/main/sqlite/sync-database.ts | Updated as part of this pull request. |
| src/main/sqlite/sync-database.test.ts | Updated as part of this pull request. |
| src/main/skills/skill-cloud-grant-installation.ts | Updated as part of this pull request. |
| src/main/runtime/structured-agent-session-integration.test.ts | Updated as part of this pull request. |
| src/main/runtime/structured-agent-session-integration-replay.test.ts | Updated as part of this pull request. |
| src/main/runtime/runtime-rpc-mobile-native-chat-settings.test.ts | Updated as part of this pull request. |
| src/main/runtime/runtime-notifier-contract.ts | Updated as part of this pull request. |
| src/main/runtime/runtime-legacy-worker-terminal-recovery-types.ts | Updated as part of this pull request. |
| src/main/runtime/runtime-legacy-worker-terminal-recovery-runner.ts | Updated as part of this pull request. |
| src/main/runtime/runtime-legacy-worker-terminal-recovery-controller.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/relay-transport.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/orchestration-mutation-request-show.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/orchestration-legacy-takeover-delivery.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/orchestration-legacy-coordinator-race.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/orchestration-legacy-compatibility-dispatcher-test-fixture.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/structured-agent-session-precommit-refusal.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/session-tab-agent-status-projection.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/session-tab-agent-capability-mutations.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/worker/worker-stop-liveness-verdict.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/worker/worker-start-outcome-classification.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/worker/worker-start-budgets.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/worker/worker-methods.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/worker/manual-dispatch-release.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/worker/folder-worktree-placement.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/runs/run-receipt.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/runs/reset-methods.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/runs/mutation-request-show.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/runs/dispatch-creator.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/rpc-test-harness.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/messaging/recipient-routing.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/messaging/ask-remote.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/gates/gates.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/gates/gate-run-authorization.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/federation/federation-request.test-support.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/federation/federation-methods.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/federation/federation-effects.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/federation/federation-effects.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/federation/federated-attach-receipt.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration/federation/federated-attach-receipt.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration-worker-methods.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/orchestration-federation-methods.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/client-ui-schemas.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/methods/client-ui-pairing-local-fields.test.ts | Updated as part of this pull request. |
| src/main/runtime/rpc/dispatcher-caller-fingerprint.ts | Updated as part of this pull request. |
| src/main/runtime/relay/relay-session-broker.ts | Updated as part of this pull request. |
| src/main/runtime/relay/relay-session-broker-contract.ts | Updated as part of this pull request. |
| src/main/runtime/relay/relay-origin-pool.ts | Updated as part of this pull request. |
| src/main/runtime/relay/desktop-relay-service.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/worker-report-observation.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/orchestration-run-list-compatibility.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/orchestration-mutation-question-db.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/orchestration-legacy-storage-db.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/orchestration-adopted-run-binding.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/lifecycle-reconciliation.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/formatter.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/federation-acknowledgment-integrity.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/db/schema/migrate-v40.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/db/runs/run-lookup.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/db/hot-path-statement-compilation.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/db/dispatch-row-writer-boundary.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/db.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/db-message-timestamp.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/db-heartbeat-straggler-guard.test.ts | Updated as part of this pull request. |
| src/main/runtime/orchestration/coordinator-task-dispatch.ts | Updated as part of this pull request. |
| src/main/runtime/orca-runtime-serialize-main-terminal-buffer.ts | Updated as part of this pull request. |
| src/main/runtime/orca-runtime-serialize-headless-terminal-buffer.ts | Updated as part of this pull request. |
| src/main/runtime/orca-runtime-remove-orphan-or-folder-worktree.ts | Updated as part of this pull request. |
| src/main/runtime/orca-runtime-register-pty.ts | Updated as part of this pull request. |
| src/main/runtime/orca-runtime-refresh-floating-workspace-pty-liveness.ts | Updated as part of this pull request. |
| src/main/runtime/orca-runtime-record-agent-prompt-lifecycle-state.ts | Updated as part of this pull request. |
| src/main/runtime/orca-runtime-close-mobile-session-tab.ts | Updated as part of this pull request. |
| src/main/runtime/mobile-rpc-allowlist.test.ts | Updated as part of this pull request. |
| src/main/runtime/folder-workspace-pty-teardown.ts | Updated as part of this pull request. |
| src/main/runtime/claude-structured-session-integration.test.ts | Updated as part of this pull request. |
| src/main/runtime/browser-session-tab-selection-snapshot.ts | Updated as part of this pull request. |
| src/main/runtime/agent-session-restart-handoff-adjudication.ts | Updated as part of this pull request. |
| src/main/runtime/agent-session-handoff-lease-transitions.ts | Updated as part of this pull request. |
| src/main/refused-tree-kill-root-termination.test.ts | Updated as part of this pull request. |
| src/main/rate-limits/service/service-types.ts | Updated as part of this pull request. |
| src/main/rate-limits/service/service-fetch-targets.ts | Updated as part of this pull request. |
| src/main/rate-limits/service-live-claude-usage.test.ts | Updated as part of this pull request. |
| src/main/rate-limits/service-inactive-account-previews.test.ts | Updated as part of this pull request. |
| src/main/rate-limits/service-antigravity-usage.test.ts | Updated as part of this pull request. |
| src/main/rate-limits/service-account-target-selection.test.ts | Updated as part of this pull request. |
| src/main/rate-limits/rate-limit-service-test-harness.ts | Updated as part of this pull request. |
| src/main/proxy-guarded-fetch-call-site-audit.test.ts | Updated as part of this pull request. |
| src/main/providers/agent-foreground-process.ts | Updated as part of this pull request. |
| src/main/pi/titlebar-extension-service.ts | Updated as part of this pull request. |
| src/main/persistence/restoring-sessions/session-worktree-ownership.ts | Updated as part of this pull request. |
| src/main/own-chromium-tree-kill-guard.test.ts | Updated as part of this pull request. |
| src/main/opencode-usage/snapshot-rollups.ts | Updated as part of this pull request. |
| src/main/native-chat/session-file-resolver-wsl-scan-gate.test.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-turns-options.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-reveal.test.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-readable-restorer.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-readable-restorer.test.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-mutation-plans.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-mutation-admission.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-launch-env.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-handoff.test.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-handoff-types.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-handoff-test-coordinator.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-handoff-reverse.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-handoff-owner-close.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-handoff-flow-runner.test.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-wire/structured-agent-session-event-recovery.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-journal/journal-store-restore.ts | Updated as part of this pull request. |
| src/main/native-chat/agent-session-journal/journal-open.ts | Updated as part of this pull request. |
| src/main/jira/jira-issue-search.ts | Updated as part of this pull request. |
| src/main/ipc/worktrees/removal/remove-folder-workspace.ts | Updated as part of this pull request. |
| src/main/ipc/runtime.test.ts | Updated as part of this pull request. |
| src/main/ipc/pty/runtime/controller.ts | Updated as part of this pull request. |
| src/main/ipc/pty/provider/registry.ts | Updated as part of this pull request. |
| src/main/ipc/pty/host-env/path.ts | Updated as part of this pull request. |
| src/main/ipc/agent-hooks.test.ts | Updated as part of this pull request. |
| src/main/global-fetch-call-site-audit.test.ts | Updated as part of this pull request. |
| src/main/daemon/daemon-server-kill-attribution.test.ts | Updated as part of this pull request. |
| src/main/daemon/daemon-request-router.ts | Updated as part of this pull request. |
| src/main/daemon/daemon-pty-event-subscriptions.ts | Updated as part of this pull request. |
| src/main/codex/codex-structured-session-options.test.ts | Updated as part of this pull request. |
| src/main/codex/codex-structured-journal-translation-turns.ts | Updated as part of this pull request. |
| src/main/codex/codex-structured-journal-limits.ts | Updated as part of this pull request. |
| src/main/codex/codex-command-lifecycle.ts | Updated as part of this pull request. |
| src/main/codex/codex-app-server-record-reader.ts | Updated as part of this pull request. |
| src/main/codex-usage/codex-usage-rollup-projections.ts | Updated as part of this pull request. |
| src/main/claude/claude-structured-session-test-support.ts | Updated as part of this pull request. |
| src/main/claude/claude-structured-location-support.test.ts | Updated as part of this pull request. |
| src/main/claude-usage/claude-usage-report-aggregation.ts | Updated as part of this pull request. |
| src/main/browser/remote-browser-socks-upstream.ts | Updated as part of this pull request. |
| src/main/browser/browser-viewport-user-agent.ts | Updated as part of this pull request. |
| src/main/browser/browser-session-partition-proxy-install.test.ts | Updated as part of this pull request. |
| src/main/browser/browser-session-partition-policies.test.ts | Updated as part of this pull request. |
| src/main/browser/browser-manager-viewport-test-fixtures.ts | Updated as part of this pull request. |
| src/main/ai-vault/session-title-file-reader.ts | Updated as part of this pull request. |
| src/main/ai-vault/session-scanner-source-discovery.ts | Updated as part of this pull request. |
| src/main/ai-vault/cached-session-list.ts | Updated as part of this pull request. |
| src/main/agent-hooks/server/server-status-identity.ts | Updated as part of this pull request. |
| src/cli/stdout-line.ts | Updated as part of this pull request. |
| src/cli/specs/orchestration.ts | Updated as part of this pull request. |
| src/cli/skills-command-flag-help.ts | Updated as part of this pull request. |
| src/cli/selectors.ts | Updated as part of this pull request. |
| src/cli/runtime/websocket-transport.test.ts | Updated as part of this pull request. |
| src/cli/root-help-text-primary.ts | Updated as part of this pull request. |
| src/cli/orchestration-mutation-recovery.ts | Updated as part of this pull request. |
| src/cli/index.ts | Updated as part of this pull request. |
| src/cli/handlers/orchestration/mutation-request.ts | Updated as part of this pull request. |
| src/cli/handlers/orchestration-task-create-cli.test.ts | Updated as part of this pull request. |
| src/cli/format.ts | Updated as part of this pull request. |
| pnpm-workspace.yaml | Updated as part of this pull request. |
| mobile/src/transport/rpc-client-capabilities.test.ts | Updated as part of this pull request. |
| mobile/src/transport/mobile-runtime-client-capabilities.ts | Updated as part of this pull request. |
| mobile/src/source-control/mobile-git-history.ts | Updated as part of this pull request. |
| mobile/src/session/use-mobile-native-chat-session-options.ts | Updated as part of this pull request. |
| mobile/src/session/use-mobile-native-chat-controller.ts | Updated as part of this pull request. |
| mobile/src/session/use-mobile-native-chat-answer-send.test.ts | Updated as part of this pull request. |
| mobile/src/session/MobileNativeChatView.tsx | Updated as part of this pull request. |
| mobile/src/session/MobileNativeChatSessionOptionPickers.tsx | Updated as part of this pull request. |
| mobile/src/session/mobile-session-route-types.ts | Updated as part of this pull request. |
| mobile/src/session/mobile-native-chat-permission-send.test.ts | Updated as part of this pull request. |
| mobile/src/session/mobile-native-chat-eligibility.ts | Updated as part of this pull request. |
| docs/site/content/docs/mobile.mdx | Updated as part of this pull request. |
| docs/site/content/docs/cli/skills.mdx | Updated as part of this pull request. |
| docs/site/content/docs/cli/reference.mdx | Updated as part of this pull request. |
| docs/site/content/docs/cli/orchestration.mdx | Updated as part of this pull request. |
| config/vitest.performance.config.ts | Updated as part of this pull request. |
| config/tsconfig.cli.json | Updated as part of this pull request. |
| config/ts-nocheck-baseline.txt | Updated as part of this pull request. |
| config/scripts/wsl-e2e-lane-contract.test.mjs | Updated as part of this pull request. |
| config/scripts/rebuild-native-deps.mjs | Updated as part of this pull request. |
| config/scripts/package-electron-runtime-contract.test.mjs | Updated as part of this pull request. |
| config/scripts/native-chat-live-session-benchmark.ts | Updated as part of this pull request. |
| config/oxlint-performance-audit.json | Updated as part of this pull request. |
| config/max-lines-baseline.txt | Updated as part of this pull request. |
| cloud/infra/terraform/variables.tf | Updated as part of this pull request. |
| cloud/infra/terraform/environments/production.tfvars | Updated as part of this pull request. |
| cloud/dev/scripts/relay-public-workflow-contract.test.mjs | Updated as part of this pull request. |
| cloud/dev/scripts/relay-production-identity-boundaries.test.mjs | Updated as part of this pull request. |
| cloud/dev/scripts/probe-relay-rehome-trust.mjs | Updated as part of this pull request. |
| cloud/dev/scripts/cloud-sql-rollout-lock-census.mjs | Updated as part of this pull request. |
| cloud/apps/relay/src/relay-server.ts | Updated as part of this pull request. |
| cloud/apps/relay/src/cell-heartbeat-client.ts | Updated as part of this pull request. |
| cloud/apps/relay/src/assignment-inventory-snapshot.ts | Updated as part of this pull request. |
| cloud/apps/relay/package.json | Updated as part of this pull request. |
| cloud/apps/relay-ops/package.json | Updated as part of this pull request. |
| cloud/apps/relay-fence-broker/package.json | Updated as part of this pull request. |
| .github/workflows/cloud-deploy-relay-production-director.yml | Updated as part of this pull request. |
| .gitattributes | Updated as part of this pull request. |
Review details
Suppressed comments (2)
mobile/src/session/MobileNativeChatSessionOptionPickers.tsx:49
- This new request-to-drawer path is not covered by the component tests: they only open pickers through the user-facing pill/row presses. Add a focused rerender test with an
optionPickerRequest(and a changed request sequence) that verifies the requested descriptor opens, so regressions in externally triggered structured-session picks are caught.
mobile/src/session/use-mobile-structured-agent-session.ts:187 - This path sends a normal message and then relies on the success handling below, but an outer RPC
status: 'accepted'does not meansubmission.dispatchStateis accepted: the host can returnrejected,unknown, orpendinginside a successful result. The current handling clears the mobile draft and reports success for those outcomes. Inspectresult.value.submission.dispatchStateas the desktop outbox does; keep unknown/pending operation ids for retry and restore/report rejected drafts.
- Files reviewed: 210/2481 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
21
to
24
| const framer = createIncrementalNdjsonFramer(input.onRecord, input.onRejected, { | ||
| maxLineBytes: input.maxRecordBytes, | ||
| // The provider owns this local stdio stream, so valid agent payloads keep full fidelity. | ||
| maxLineBytes: Number.POSITIVE_INFINITY, | ||
| shouldPause: () => paused |
Comment on lines
+48
to
+50
| if (!identity) { | ||
| return { ...childEnv, [ORCA_STRUCTURED_SESSION_ENV]: '1' } | ||
| } |
… tests
Seven CI failures, all one cause each:
- the fork's mid-draft slash match was lost when `native-chat-picker-items.ts`
reset to the tag; upstream anchors `/` at the start of the draft, this fork
offers the picker after any whitespace. Restored.
- the SSH ack path's fork test still minted `{ ok }` settlements; v1.4.200
replaced that with the `accepted`/`refused`/`unverifiable` union.
- `focus-terminal-tab-surface` now scopes its tab-wide lookup to uncovered
leaves, so the dock-redirect test's stub answered a selector the code no
longer builds.
- the run header repeats each member's name, so the coloring test's
`getByText('Bash')` became ambiguous; it asserts on the row's own `<code>`.
- three upstream cases assert argument shapes this fork widens — the reveal and
chat-coverage recoveries both carry dock focus ownership.
- upstream's structured-send IME test now drives its tiptap prompt editor; this
fork's composer field is a textarea, so the test drives it with change events.
zpyoung
deleted the
zpyoung/auto-sync-fork-with-upstream-stablyai-orca-ru-20260911T1400
branch
September 11, 2026 15:33
zpyoung
pushed a commit
that referenced
this pull request
Oct 19, 2026
…f the deprecated owner resolver; spawn refuses folder twins (stablyai#30497) * refactor(renderer): fold launch, resume, note-send, paste and terminal-create callers off the deprecated owner resolver Agent launch, AI-vault resume and reveal, note target and send, wake and creation seeds, native chat owner, the shell menu and active-workspace terminal creation (#22, #31-#42, #44) read the owner through runtimeEnvironmentIdWithLegacyFallbackUnlessTwin. Paste uploads images to the server its PTY id names before falling back to the workspace owner. The folder and floating branch of the terminal spawn route (#53) reads resolveOwnerWithLegacyFallback: spawn refuses a folder twin instead of following the focused server, and teardown keeps tearing raw ids down locally. Deprecated importers 31 -> 16. * test: give the paste-listener and tab-bar probes the fields the folded callers read * test: note why the folder-twin route fixture is cast * test: type the paste-owner twin fixture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target
Upstream stable tag v1.4.200 at
f352b6b08d9028ba8b577d6ac8a8247c2a6c9c92, merged into thisrun branch.
mainwas at494e45f9c1f2fde90b4aaf5d04ae4296c36a338e; the previous stable tag itcarried was v1.4.198, so this absorbs two releases (v1.4.199 was never synced).
Backup:
origin/backup/main-20260911-140212Zat494e45f9c1.Resolution
resolution = auto-ours+tree. Attempt 1 conflicted;-X ourscompleted with three"deleted by us / modified by them" tree conflicts, all three declared
deleted: truein themanifest, so the fork's deletion was honoured:
src/renderer/src/components/native-chat/NativeChatComposerField.tsxsrc/renderer/src/components/native-chat/native-chat-composer-composition.test.tsxsrc/renderer/src/components/native-chat/native-chat-draft-cache.tsNo conflict markers survived.
Fork commits
N = 376, every SHA confirmed still reachable at its original SHA
(
git merge-base --is-ancestorover the full set; 0 unreachable). The post-merge range is 377 —the 376 plus the single ownership commit.
Ownership lists
node config/scripts/sync-upstream-file-ownership.mjs v1.4.200 494e45f9c1 <out>sorted 3394differing paths:
checkout.txtremove.txtours.txtmerge-review.txtcheckout.txtsweep — 11 undeclared fork edits recoveredThe reset reverted eleven fork edits that no manifest entry declared. All eleven were real, all are
restored (three-way merged against the tag where upstream had also moved), and all eleven are now
declared as seams with residual budgets so the next sync keeps them:
src/main/providers/ssh-pty-provider.ts,src/main/runtime/mobile-session-terminal-projection.ts,src/main/runtime/orca-runtime-publish-pty-backed-mobile-session-terminal.ts,src/main/runtime/orca-runtime-runtime-id.ts,src/main/runtime/runtime-mobile-session-projection.ts,src/preload/index.ts,src/renderer/src/components/native-chat/NativeChatMessageList.tsx,src/renderer/src/components/native-chat/NativeChatToolRun.tsx,src/renderer/src/components/native-chat/use-native-chat-structured-composer-send.ts,src/renderer/src/lib/pane-manager/terminal-scroll-intent-key-retention.test.ts,src/shared/structured-agent-session-options.ts.Cause: the v1.4.198 sync's barrel re-home (
4ef6b1dbd9) moved these declarations to new paths anddropped the originals while the fork edits stayed in the old files.
ours.txtaudit — 17 paths where upstream also movedEvery one took a real three-way merge with v1.4.198 as base. Notable:
package.json— fork version kept, everything else upstream's:electron 43.6.0,dompurify 3.4.14,react-i18next 17.0.13, newesbuild,bench:spinners, and the--project electron-headfulgolden lane.pnpm install --frozen-lockfilepasses.config/reliability-gates.jsonc— upstream's +1090/-81 taken whole.config/scripts/package-electron-runtime-contract.test.mjs— took upstream's new golden-projectassertions; kept the fork's removal of the Windows/posix golden assertions (ci: cap sync-sized PR scans and remove Windows lanes #52).
.github/workflows/pr.yml— upstream's only delta adds two Windows test files to the Windowspackage job, which this fork deleted; nothing to replay. No pnpm/node toolchain bump in this range.
merge-review.txt— 12 drifted seam residuals, each re-readnative-chat/NativeChatComposer.tsxsendStructuredfor upstream's hook (takeover reporting + draft-change guard), wireduseNativeChatComposerCatalog, passedpaneKeyto the drop hooknative-chat/native-chat-picker-items.tspickerSkill(), fork namespacing applied per namenative-chat/native-chat-composer-state.tssessionSkillNamesandnamespacesPluginSkillsthreaded through the/and$derivationsnative-chat/native-chat-composer-types.tsconversationCommands+ the fork's attachment typenative-chat/use-native-chat-session-options.tsnative-chat/use-native-chat-composer-attachments.tsruntime/rpc/methods/native-chat.test.tsright-sidebar/AiVaultSessionVirtualList.tsxAiVaultVirtualRow; the session-handoff seam re-homed into it and the list file is byte-identical to the tagright-sidebar/ai-vault-session-launch-actions.tsterminal-pane/pane-helpers.tsfocusPanePreservingOverlays+ the fork's dock focus ownershipterminal-pane/terminal-visibility-resume.ts/.test.tsisChatViewModegate composed with the fork's ownership args; both test suites keptAlso repaired, found by lint rather than by the residual check:
terminal-pane/use-terminal-window-wake-recovery.ts—-X oursdroppedisChatViewModefrom theeffect's dependency array while keeping upstream's use of it inside. Restored.
Tier-4 — a pending-upstream item landed upstream
v1.4.200 (stablyai#19328) implements the fork's composer file-drop pane scoping, as
scopeKeyinstead ofthe fork's
tabId/paneLeafId. Taken whole:src/shared/native-file-drop.ts,src/shared/native-file-drop.test.tsanduse-native-chat-file-attachment-actions.tsare now upstream's.pending-upstreamexceptions and thedocs/fork-upstreaming.md#composer-file-drop-pane-scopingsection are removed together.AgentComposerFieldnow publishesdata-composer-scope-keyin place of the twoterminal attributes, so upstream's resolver addresses it.
coverage against the fork's own field).
Also repointed the orphaned
live-claude-rate-limit-ingest-acceptanceledger entry atsrc/main/rate-limits/service/service-fetch-policy.ts, where v1.4.186's split moved it.Withdrawn deletions
v1.4.200 adds a contenteditable prompt editor (
NativeChatPromptEditor, tiptap) plusnative-chat-composer-drop-scope.test.tsxanduse-native-chat-composer-catalog.test.tsx. Those newupstream files import modules the fork deleted against v1.4.198's import graph. Eight
deleted: trueexceptions are withdrawn so upstream's own code compiles:
native-chat-draft-cache.ts,native-chat-composer-scope-cache.ts,NativeChatImageAttachmentPreview.tsx,use-native-chat-composer-keydown.tsand each one's test.Nothing the fork ships changes:
NativeChatComposerField.tsxstays deleted and the fork's composerkeeps its own field, caches, and keydown copy.
NativeChatImageAttachmentPreviewtakes animport-swap seam onto the fork's attachment type;
native-chat-composer-state.tsre-exports thefork's history surface for upstream's restored keydown hook.
Tier-2 forked-copy replay
16 copies checked against
FORK-COPY-SHA e0826956fc→ v1.4.200. Three recorded paths moved:use-agent-composer-keydown.ts— replayed (KeyboardEventHandler<HTMLElement>); header advancedto
f352b6b08d.AgentComposerField.tsxandagent-composer-autogrow.test.tsx— upstream's delta is thetextarea → contenteditable rework. Deliberately not replayed, and their headers are
left at
e0826956fcso the next run still sees it. See "Needs attention".No
Ddeltas. Two copies carry their headers on lines 2-3 behind a// @vitest-environmentpragma.Upstream feature-collision review
All 14 features compared against the 288 commits in
v1.4.198..v1.4.200:none— worktree-groups, native-chat-relay, native-chat-coloring, native-chat-width, terminal-dock,skill-plugin-attribution, dirty-branch-indicator, artifact-passwords, session-info,
sidebar-section-separator.
possible(raised, nothing chosen) — agent-composer, native-chat-session-options,live-plugin-marketplaces, session-handoff. Detail under "Needs attention".
Verification
pnpm install --frozen-lockfile--verify-seams--verify-residuals v1.4.200pnpm typecheck:node/:web/:cliAGENTS.mdforbids the concurrent form here)pnpm lintorigin/main HEAD)mainRegenerated as part of the resolution:
config/max-lines-baseline.txt(pruned 3 stale entries),src/renderer/src/i18n/en-runtime-required.json,resources/skills/current-manifest.jsonandsnapshot-registry.json(release-mapping.jsonuntouched, so the fork's tagless ledger stands).Tests are left to this PR's own CI, per the skill.
Needs attention
agent-composervs upstream's prompt editor (possible). v1.4.200 replaced upstream'scomposer textarea with a tiptap contenteditable editor. The fork's tier-2 copy stays on the
textarea and its
FORK-COPY-SHAis deliberately not advanced. Decide: adopt the editor into thefork copy, or accept permanent tier-2 divergence here.
native-chat-session-optionsvs fix(native-chat): remember structured chat model and effort picks stablyai/orca#19147 (possible). Upstream now persists structured-chatmodel/effort picks to
nativeChatSessionOptions; the fork pre-fills the same two from agentsession logs and Claude's startup frame. Different sources, same goal.
session-handoffvs feat(native-chat): resume an Agent Session History row into a new structured chat stablyai/orca#19176 (possible). Upstream added "Resume in New Chat" on AgentSession History rows; the fork's Continue-in-New-Session adds a rich brief to the same rows.
live-plugin-marketplacesvs fix(native-chat): list the slash commands and skills a structured Claude session actually loaded stablyai/orca#19127 (possible). Upstream now lists the slash commands andskills a structured Claude session actually loaded; the fork points the picker at a directory
marketplace's live plugin directory.
pnpm typecheck:e2ereports 197 errors, none of them the fork's. The failing files arebyte-identical to v1.4.200 and reference symbols absent from the tag's own
src(e.g.toggleWorktreeCardProperty).tsconfig.e2e.jsonis not part ofpnpm typecheck, so no CI gatecovers it — this is upstream release-branch incoherence, recorded rather than worked around.
seamhas nowhere to record itsledgerpointer.service-fetch-policy.tsis tracked that way since v1.4.186's split; the ledger section wasorphaned until this run repointed it by hand.