Repository navigation
sync-skill: catch balanced -X ours seam damage, and stop typechecking the retired mobile-web project - #99
sync-skill: catch balanced -X ours seam damage, and stop typechecking the retired mobile-web project#99zpyoung wants to merge 1 commit into
Conversation
…d mobile-web typecheck
|
| no shell command: those paths took a real three-way merge and must be read by hand against the | ||
| manifest's declared lines. | ||
|
|
||
| `-X ours` resolved every conflicting hunk in those files toward the fork, so re-merge each seam file |
There was a problem hiding this comment.
Seam command lacks file inputs The new check names three commits, but
git merge-file needs three file paths for each seam. It also prints the result rather than updating the seam file. Without instructions to extract those files and apply the result, an operator cannot reliably complete this required check.
|
|
||
| ```sh |
There was a problem hiding this comment.
Typecheck instructions disagree This step says to use the tag runner's
TYPECHECK_PROJECTS, but shows a fixed set of three commands; the ownership reference still calls them four commands. The current fork runner uses a waves list, not TYPECHECK_PROJECTS. If a tag lists a different set of projects, following the displayed commands can leave one unchecked. Please make the gate and its reference agree on how to follow the tag's list.
Two findings from the v1.4.215 sync run (#98). Both are reproducible against that tag.
1. Step 8's fourth typecheck project no longer exists
v1.4.215 retired
config/tsconfig.mobile-web.jsonin stablyai#22193 (git cat-file -e v1.4.215:config/tsconfig.mobile-web.jsonfails), and dropped it fromTYPECHECK_PROJECTSinrun-typecheck-projects-in-parallel.mjs. The gate's fourth command now fails with a missing-file error that says nothing about types.Edit: Step 8 now runs node, web and cli, and tells the run to read the project list from the tag's runner script instead of trusting the skill's copy.
references/file-ownership.mdno longer says "four".2.
--verify-residualsmisses-X oursdamage when the line counts balanceOn #98, re-merging every seam file with
git merge-file --diff3(basev1.4.207, ours9710c6b44b, theirsv1.4.215) found 18 conflicted files.--verify-residualshad flagged only 16 of them. The other two kept their budgets:config/scripts/pr-e2e-gate-contract.test.mjs: still namesroot_directory_guard, a job upstream removed.src/renderer/src/components/native-chat/NativeChatToolLine.tsx: lost upstream'sgroup-hover/tool-linerename, so the fork's hover styling stopped firing.The
ours.txtthree-way merge has a related blind spot. It pulled upstream's new assertions abouttrack-community-prs.yamlandpackage_windowsinto two exception-owned contract tests, even though the fork deletes both. Nothing flagged it until PR CI.Edit: Step 6 now requires a clean re-merge of every seam file, and a grep of merged exception tests for deleted paths and jobs missing from the fork's
pr.yml.Scope is
.claude/skills/sync-upstream/**only. Safety rules and the fix policy's never-list are untouched.