Repository navigation
Preserve configured SSO login in web releases - #15
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A web-only upgrade could retain the configured OIDC server while replacing its browser login with a password-only page. The server's SSO settings were returned by
/api/setup-status, but the new login only checked/api/auth-config.The auth gate now carries the configured OIDC provider and password policy into the login page. SSO-only instances display their provider button and hide password/invite controls; older servers retain password login. Invalid status responses retry and show the existing error screen instead of selecting a login method.
Validation: formatting, lint, 45 typecheck tasks and 39 workspace test tasks passed. Added a logged-out browser scenario for configured methods at desktop and phone widths; the production-image regression reproduces with the previous assets and passes with the corrected assets in both SSO-only and password-enabled configurations, with external networking disabled. The deployed logged-out page also passes at desktop and phone widths. A separate live check confirms that the provider button sends the correct provider ID and redirects to the configured SSO origin; no user authentication was completed.