Skip to content

Implement multi language in fragments #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuentinouLeTwist wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement multi language in fragments #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = async options => {
}

if (options.data) {
newOptions.data = options.isFragment ? createDocument(options.data) : options.data
newOptions.data = options.isFragment ? createDocument(options.data, options.language ?? 'en') : options.data
newOptions.method = 'post'
if (!newOptions.headers['Content-Type']) {
newOptions.headers['Content-Type'] = 'text/html; charset=utf-8'
Expand Down
2 changes: 1 addition & 1 deletion lib/create-document-from-fragment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = fragment => `<!DOCTYPE html><html lang="en"><head><title>Document from fragment</title></head><body>${fragment}</body></html>`
module.exports = (fragment, lang = 'en') => `<!DOCTYPE html><html lang="${lang}"><head><title>Document from fragment</title></head><body>${fragment}</body></html>`
2 changes: 1 addition & 1 deletion test/lib/create-document-from-fragment-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const createDocument = require('../../lib/create-document-from-fragment')

tap.test('returns document from fragment', test => {
const fragment = '<p>This is a fragment</p>'
const document = createDocument(fragment)
const document = createDocument(fragment, 'en')
const expectedDocument = '<!DOCTYPE html><html lang="en"><head><title>Document from fragment</title></head><body><p>This is a fragment</p></body></html>'
tap.equal(document, expectedDocument, 'document is correct')
test.end()
Expand Down