This repository was archived by the owner on Apr 23, 2024. It is now read-only.
修复一些bug和增加一些手机型号的判断#3
Open
elrichuang wants to merge 1 commit into
Open
Conversation
elrichuang
commented
May 5, 2015
- 修复autoload文件时路径错误;
- 优先检测微信,然后再是QQ浏览器;
- 增加多种手机型号检测;
- 系统检测区分iphone,ipod,ipad和mac;
2. 优先检测微信,然后再是QQ浏览器; 3. 增加多种手机型号检测; 4. 系统检测区分iphone,ipod,ipad和mac;
Owner
|
因为没有提交测试(tests/TestUserAgent.php),故暂难以合并,抱歉。 我的代码采用了phpfmt作为代码格式化工具,采用phpunit作为单元测试工具,以此保证在版本迭代时一些特殊User-Agent的判断不会出错。目前的代码测试覆盖率约为80%以上,请您也为您提交的代码编写测试。另外因为我的代码覆盖率测试工具为phpunit所自带故未在GitHub上挂Coverage Badge。 |
Owner
|
https://travis-ci.org/zsxsoft/php-useragent/jobs/61236566 |
Author
|
你的单元测试报错那里我好像没有改过 |
Owner
|
是这样的,这说明你做的修改导致了判断出错。这只能说明你加入的规则和原来的规则产生了冲突,估计是优先级问题吧我想。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.