Skip to content
This repository was archived by the owner on Apr 23, 2024. It is now read-only.

修复一些bug和增加一些手机型号的判断#3

Open
elrichuang wants to merge 1 commit into
zsxsoft:masterfrom
elrichuang:master
Open

修复一些bug和增加一些手机型号的判断#3
elrichuang wants to merge 1 commit into
zsxsoft:masterfrom
elrichuang:master

Conversation

@elrichuang

Copy link
Copy Markdown
  1. 修复autoload文件时路径错误;
  2. 优先检测微信,然后再是QQ浏览器;
  3. 增加多种手机型号检测;
  4. 系统检测区分iphone,ipod,ipad和mac;

2. 优先检测微信,然后再是QQ浏览器;
3. 增加多种手机型号检测;
4. 系统检测区分iphone,ipod,ipad和mac;
@zsxsoft

zsxsoft commented May 8, 2015

Copy link
Copy Markdown
Owner

因为没有提交测试(tests/TestUserAgent.php),故暂难以合并,抱歉。

我的代码采用了phpfmt作为代码格式化工具,采用phpunit作为单元测试工具,以此保证在版本迭代时一些特殊User-Agent的判断不会出错。目前的代码测试覆盖率约为80%以上,请您也为您提交的代码编写测试。另外因为我的代码覆盖率测试工具为phpunit所自带故未在GitHub上挂Coverage Badge。

@zsxsoft

zsxsoft commented May 8, 2015

Copy link
Copy Markdown
Owner

https://travis-ci.org/zsxsoft/php-useragent/jobs/61236566
而且看起来我原来的单元测试都没过的样子 Σ( ° △ °|||)︴

@elrichuang

Copy link
Copy Markdown
Author

你的单元测试报错那里我好像没有改过

@zsxsoft

zsxsoft commented May 8, 2015

Copy link
Copy Markdown
Owner

是这样的,这说明你做的修改导致了判断出错。这只能说明你加入的规则和原来的规则产生了冲突,估计是优先级问题吧我想。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants