PostgreSQL 18 support

[devrimgunduz]

Hi,

v18 beta1 is out. pg_profile builds fine against it, but regression tests fail. A sample is below. Can you please take a look? Thanks! Devrim

 /* Testing sample creation */
 -- (sample 1)
 SELECT server,result FROM profile.take_sample();
- server | result
---------+--------
- local  | OK
+ server |                                               result
+--------+-----------------------------------------------------------------------------------------------------
+ local  | Unsupported pg_stat_statements extension version.                                                  +
+        | PL/pgSQL function collect_pg_stat_statements_stats(jsonb,integer,integer,integer) line 329 at RAISE+
+        | SQL statement "SELECT collect_pg_stat_statements_stats(server_properties, sserver_id, s_id, topn)" +
+        | PL/pgSQL function take_sample(integer,boolean) line 639 at PERFORM                                 +
+        | PL/pgSQL function take_sample_subset(integer,integer) line 37 at assignment                        +
+        | SQL function "take_sample" statement 1                                                             +
+        |
 (1 row)

[zubkov-andrei]

Hi! Support of pg18 is in progress. There is some new statistics added and those are needed in reports, I think we'll be ready in couple weeks.

[zubkov-andrei]

Hi
Version 4.10 supporting of PostgreSQL 18 is ready and tested.

[devrimgunduz]

I'm still seeing the same errors

[zubkov-andrei]

Hi, we've released version 4.11 with some bugs fixed. Is it possible to include it as a package in the binary repo?

[devrimgunduz]

I've already pushed 4.1.1 in November. Regression tests still fail. Diff is attached.

pg_profile_4.1.1.-pg18-regression.diffs.txt

[zubkov-andrei]

I've already pushed 4.1.1 in November. Regression tests still fail. Diff is attached.

pg_profile_4.1.1.-pg18-regression.diffs.txt

Thank you for the detailed report. I'll fix it today.

[zubkov-andrei]

@devrimgunduz can you double check your test environment? It looks very strange.

@@ -46,7 +46,7 @@
 -- settings validation test
 SELECT profile.set_server_setting('srvtestrenamed','name_failure','test');
 ERROR:  Unsupported setting
-CONTEXT:  PL/pgSQL function set_server_setting(name,text,text) line 53 at RAISE
+CONTEXT:  PL/pgSQL function set_server_setting(name,text,text) line 41 at RAISE
 SELECT profile.set_server_size_sampling( server => 'srvtestrenamed', collect_mode => 'on' );
  set_server_size_sampling 

While commit 2ca88be simultaneously changes the function set_server_size_sampling adding 12 strings there and corresponding test changing line 41 to line 53. I.e. RAISE mentioned here can't be on the line 41 as it is on line 53 of a function on the current master (file management/server.sql:452).

The rest errors mostly caused by this:
pg_stat_statements must be loaded via "shared_preload_libraries"
As pg_stat_statements statistics are very valuable to the most pg_profile use cases, those are tested, but they need pgss binary to be in shared_preload_libraries. Can you set in there on your test environment?