avoid dependency on ldap by optionally faking the exceptions - #13
avoid dependency on ldap by optionally faking the exceptions#13graingert wants to merge 1 commit into
Conversation
|
@eeshangarg we currently use |
|
this also allows people to test without having |
|
@graingert: Thanks for working on this! Looks good to me! :) @timabbott: Could you please take a quick look as well? Thanks! |
| class LDAPError(Exception): pass | ||
| class INVALID_CREDENTIALS(LDAPError): pass | ||
| class NO_SUCH_OBJECT(LDAPError): pass | ||
| class ALREADY_EXISTS(LDAPError): pass |
There was a problem hiding this comment.
Can you add a comment here explaining the motivation from the PR description? I think it'll be helpful for future folks reading the code to not need to spelink.
|
Makes sense to me; posted a quick comment on documentation. |
|
Possibly we should also add a brief section at the bottom of the README mentioning this behavior, maybe with a title like "Usage without ldap installed". |
No description provided.