WIP: fakeldap.py: Don't rely on KeyError exceptions when accessing non-exi… - #18
Open
sunweaver wants to merge 1 commit into
Open
Conversation
…stent keys of MockLDAP.directory.
The implementation of the internal MockLDAP.directory dictionary is
defined via
self.directory = defaultdict(lambda: {})
This results in a dictionary that always returns an empty dict for any
key requested:
>>> print (self.directory['some_key'])
{}
Thus, we cannot rely on the raisal of KeyError exceptions when accessing
a non-existing LDAP DNs in the MockLDAP.directory.
Instead, we check if MockLDAP.directory['some_key'] returns an empty
dict {} value.
sunweaver
force-pushed
the
pr/directory-defaultdict-always-contains-empty-dict
branch
from
November 18, 2020 13:28
5e17fb5 to
1ca67a2
Compare
Contributor
Author
|
Please wait with reviewing this PR until #21 has been finally merged. |
sunweaver
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…stent keys of MockLDAP.directory.
The implementation of the internal MockLDAP.directory dictionary is
defined via
.
self.directory = defaultdict(lambda: {})
.
This results in a dictionary that always returns an empty dict for any
key requested:
.
>>> print (self.directory['some_key'])
{}
.
Thus, we cannot rely on the raisal of KeyError exceptions when accessing
a non-existing LDAP DNs in the MockLDAP.directory.
.
Instead, we check if MockLDAP.directory['some_key'] returns an empty
dict {} value.