Skip to content

Avoid full-suite fallback for ordinary documentation in affected PR tests #1177

Closed

Description

@zzet

The affected-test trial currently falls back to the full cross-platform suite for every non-Go file, including ordinary documentation. This defeats selective testing for PRs that include code/tests together with user-facing docs.

Concrete observation: PR #1172 at e6a8b4b799 changes CLI tests and recovery documentation. CI run 40879226996 selected full mode with reason full fallback for M: docs/cli.md, scheduling all indexer and store groups as well as CLI tests. There is no ci:full label or repository override on that run.

Extend selection narrowly for added/modified ordinary Markdown documentation under docs/. Validate the paths and supported package metadata so embedded or otherwise owned build/test inputs cannot be silently ignored. A mixed code/docs PR should retain the affected Go package closure; a verified docs-only PR may use the existing explicit empty selection. Keep full lint, builds and security checks.

Required controls:

  • Mixed ordinary Go/test changes plus documentation select the same affected packages as the Go changes alone.
  • Verified docs-only changes produce an explicit valid empty test selection.
  • Embedded Markdown and uncertain ownership still fall back to full.
  • Dependency changes (including Dependabot), CI/policy changes, unknown non-Go inputs and ci:full remain full; main always runs the full suite.
  • Rename/delete/symlink or unsupported paths retain conservative behavior.
  • Update the CI-testing documentation and run meaningful selector/runner/workflow tests and the prescribed pinned checks before pushing.

One issue, one isolated worktree and one PR. This is a focused improvement to the existing CI trial requested by the user; it does not waive release acceptance tests or change the currently running PR's plan.

Activity

  1. added this to the v0.64.12 milestone on Oct 29, 2026
  2. moved this from Todo to In Progress in Gortexon Oct 29, 2026
  3. moved this from In Progress to Done in Gortexon Oct 29, 2026
  4. zzet commented on Oct 29, 2026

    @zzet
    OwnerAuthor

    Accepted and merged through #1179 as fb70903374db9fdacb867a719c5e288dd5466516. The issue is closed and marked Done on the project board.

    Qualified added/modified Markdown under docs/ now preserves the affected Go test closure. Verified docs-only changes produce an explicit sealed empty selection. Unknown inputs, dependency updates, Dependabot, CI-policy changes, main and full overrides retain full-suite behavior; builds, lint, smoke and security remain enabled.

    The final head ba779aa45b5b1bc22d1c3f26938ec68842370ffa passed hosted CI (23 successful, two skipped checks), after the full selector/result-gate race suites and all prescribed local checks. A Windows CRLF warning exposed a fixture hash problem; the correction uses raw symlink blob bytes and passes the forced-CRLF regression. The original failed head remains in CI history.

    Mixed Go/docs, docs-only manifest/result outputs, dependency/full overrides, uncertain ownership/content, symlink modes and tested-merge-base behavior have regression coverage. Full main-branch CI follows the merge. Actual time savings will be observed on subsequent qualifying PRs; no measured speedup is claimed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    • Status
      Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions