Repository navigation
claudecode: single-quote hook binary path for shell safety - #1200
Merged
Merged
Conversation
ResolveHookCommand bakes `shellSafeHookBinary(bin) + " hook"` into ~/.claude/settings.json and Claude Code runs it through its shell. The path was only backslash-normalized, so a space would word-split the command and a $var/backtick would expand at hook-fire time. Quote the path (POSIX single-quotes, with \'\' escaping) whenever it contains a character a shell would interpret; a normal install path is emitted unchanged, and the PATH-fallback bare word needs no quoting. Two regression cases added. Co-authored-by: security audit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ResolveHookCommandbakesshellSafeHookBinary(bin) + " hook"into~/.claude/settings.json, and Claude Code runs it through its shell (Git Bash on Windows). The path was only backslash-normalized, so a space would word-split the command and a$var/backtick would expand at hook-fire time.Finding (verified empirically)
Claude Code runs hooks through a shell; the binary path is operator-set by the install location, so this is only reachable if gortex is installed at an attacker-influenced path — but the fix is a one-liner.
Fix
shellSafeHookBinarynow single-quotes the path (POSIX quotes, with the standard'\''escape) whenever it contains a character a shell would interpret, via a safe-token regex ([A-Za-z0-9_./:+]). A normal installpath (
/opt/homebrew/bin/gortex) is emitted unchanged; a bare word from the PATH fallback needs no quoting. Two regression cases added.