Skip to content

Accept and use tiled CT logs for TLS CT checks - #235

Merged
mikeperry-tor merged 2 commits into
13rac1:mainfrom
mikeperry-tor:google-ctfix
Nov 14, 2026
Merged

mikeperry-tor merged 2 commits into
13rac1:mainfrom
mikeperry-tor:google-ctfix

Conversation

@mikeperry-tor

Copy link
Copy Markdown
Collaborator

Bold of Rekor to change their TLS deployment workflow and policy to a brand new mechanism on a Saturday. I guess agents dont have weekends.

Problem

Rekor switched to tiled CT

Change

adds tiled CT

Effect

Rekor and sigstore checks work

To verify

Run live API integration

Checklist

  • [ x] I added unit tests for new code and regression tests for fixed bugs.
  • [ x] make check passes.
  • For a major feature: make integration and make reports pass.
  • [ x] I updated the documentation that this change affects.

Bold of Rekor to change their TLS deployment workflow and policy to a brand
new mechanism on a Saturday. I guess agents dont have weekends.
Copilot AI balanced review requested due to automatic review settings November 14, 2026 20:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.

🟡 Changes recommended

Documentation currently references a non-existent tiled-log test/file and the new tiled CT log verification path lacks a unit test exercising FindTiledLogByKeyHash, leaving unverified behavior and misleading coverage claims.

2 open issues
What changed in this PR

Updates TLS Certificate Transparency verification to accept SCT Log IDs from both classic RFC 6962 CT logs and newer “tiled” CT logs so Rekor/sigstore TLS CT checks continue to work.

Changes:

  • Extend SCT log-key resolution to search both standard and tiled CT log collections during verification.
  • Update transport documentation to describe CT log list usage/caching and tiled-log behavior.
  • Update the transport testing matrix to cover CT/tiled-log verification expectations (currently references a missing test).
File Description
internal/​tlsct/​checker.go Extends SCT verification to resolve log public keys from both RFC 6962 and tiled CT log collections when validating SCTs.
docs/​transport/​testing.md Updates the transport testing matrix to include CT/tiled-log behavior and references intended coverage.
docs/​transport/​README.md Documents CT log list sourcing/caching and clarifies tiled CT log handling during SCT verification.

Review effort: Balanced

Comment thread internal/tlsct/checker.go
Comment on lines +262 to +267
key, found := ctLogKey(logList, candidate.sct.LogID.KeyID)
if !found {
verifyErrs = append(verifyErrs, "SCT log ID not found in trusted log list")
continue
}
pub, pkErr := ctx509.ParsePKIXPublicKey(log.Key)
pub, pkErr := ctx509.ParsePKIXPublicKey(key)
Comment thread docs/transport/testing.md

| Behavior to preserve | Representative coverage |
| --- | --- |
| RFC 6962 and tiled CT logs verify signed SCTs during concurrent checks; unknown log IDs, invalid keys, and invalid signatures fail closed | `TestCheckTLSState_LogCollections` in [CT log tests](../../internal/tlsct/tiled_logs_test.go) |
@ai-13rac1

Copy link
Copy Markdown
Contributor

Summary

The change is correct and fixes the Rekor failure. I found no defect that blocks the merge.

  • ctLogKey (internal/tlsct/checker.go:288-296) tries FindLogByKeyHash, then FindTiledLogByKeyHash. A tiled-log SCT then goes through the same ctutil.VerifySCT call as an RFC 6962 SCT. An unknown log ID, an unparseable key and a bad signature still fail.
  • The current rekor.sigstore.dev leaf (issued 2026-11-14 14:05Z) carries SCTs from two tiled logs: Let's Encrypt Sycamore2027h1 and Geomys Tuscolo2027h1. Both are usable in Google's list of 2026-11-14, and their keys are found with this change.
  • go test -race ./internal/tlsct passes on c859958.

Findings

Log state is not checked (not a blocker, tracked in #236)

ctLogKey returns the key of any listed log, whatever its state. The RFC 6962 lookup already behaves this way. With the tiled collection, the accepted set grows: in the list of 2026-11-14, the tiled logs include 5 rejected logs, 8 pending logs and 37 logs with no state.

When the state check of #236 lands, the fixture in internal/tlsct/tiled_logs_test.go:47-53 needs a State (for example Usable). Without one, its "valid" case fails.

Documentation

Test

  • TestCheckTLSState_LogCollections signs a real SCT and checks it through the production verification path, with 8 concurrent checks on one checker under -race. That is good coverage.
  • Minor: a failing case prints its message up to 8 times, and the message is not in got/want form.

Comparison of log IDs

FindTiledLogByKeyHash compares log IDs with bytes.Equal inside the library, as FindLogByKeyHash already does for RFC 6962 logs. A log ID is the public hash of a log's public key, so this leaks nothing.

@mikeperry-tor
mikeperry-tor merged commit 6548996 into 13rac1:main Nov 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants