Repository navigation
Accept and use tiled CT logs for TLS CT checks - #235
Conversation
Bold of Rekor to change their TLS deployment workflow and policy to a brand new mechanism on a Saturday. I guess agents dont have weekends.
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟡 Changes recommended
Documentation currently references a non-existent tiled-log test/file and the new tiled CT log verification path lacks a unit test exercising FindTiledLogByKeyHash, leaving unverified behavior and misleading coverage claims.
2 open issues
What changed in this PR
Updates TLS Certificate Transparency verification to accept SCT Log IDs from both classic RFC 6962 CT logs and newer “tiled” CT logs so Rekor/sigstore TLS CT checks continue to work.
Changes:
- Extend SCT log-key resolution to search both standard and tiled CT log collections during verification.
- Update transport documentation to describe CT log list usage/caching and tiled-log behavior.
- Update the transport testing matrix to cover CT/tiled-log verification expectations (currently references a missing test).
| File | Description |
|---|---|
| internal/tlsct/checker.go | Extends SCT verification to resolve log public keys from both RFC 6962 and tiled CT log collections when validating SCTs. |
| docs/transport/testing.md | Updates the transport testing matrix to include CT/tiled-log behavior and references intended coverage. |
| docs/transport/README.md | Documents CT log list sourcing/caching and clarifies tiled CT log handling during SCT verification. |
Review effort: Balanced
| key, found := ctLogKey(logList, candidate.sct.LogID.KeyID) | ||
| if !found { | ||
| verifyErrs = append(verifyErrs, "SCT log ID not found in trusted log list") | ||
| continue | ||
| } | ||
| pub, pkErr := ctx509.ParsePKIXPublicKey(log.Key) | ||
| pub, pkErr := ctx509.ParsePKIXPublicKey(key) |
|
|
||
| | Behavior to preserve | Representative coverage | | ||
| | --- | --- | | ||
| | RFC 6962 and tiled CT logs verify signed SCTs during concurrent checks; unknown log IDs, invalid keys, and invalid signatures fail closed | `TestCheckTLSState_LogCollections` in [CT log tests](../../internal/tlsct/tiled_logs_test.go) | |
SummaryThe change is correct and fixes the Rekor failure. I found no defect that blocks the merge.
FindingsLog state is not checked (not a blocker, tracked in #236)
When the state check of #236 lands, the fixture in Documentation
Test
Comparison of log IDs
|


Bold of Rekor to change their TLS deployment workflow and policy to a brand new mechanism on a Saturday. I guess agents dont have weekends.
Problem
Rekor switched to tiled CT
Change
adds tiled CT
Effect
Rekor and sigstore checks work
To verify
Run live API integration
Checklist
make checkpasses.make integrationandmake reportspass.