Add log directory configuration for macOS - #164
Merged
Conversation
Closed
1lck
reviewed
Aug 18, 2026
1lck
reviewed
Aug 18, 2026
Collaborator
|
基本没啥问题了 |
1lck
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a user-configurable log directory for the Lithe macOS app, allowing users to view, set, and restore the directory where logs are saved. The changes include updates to the settings model, UI enhancements in the settings view, new persistence logic, and comprehensive tests to ensure correct behavior. Additionally, a requirements specification document has been added to clarify the scope and acceptance criteria for this feature.
Log Directory Customization
customLogDirectoryproperty toAppSettings, with logic to persist, restore, and reset the custom log directory. The effective log directory is now determined by this setting, defaulting to the standard user logs location if unset. (Sources/Lithe/Models/Settings/AppSettings.swift) [1] [2] [3] [4] [5]Sources/Lithe/Views/App/SettingsView.swift) [1] [2] [3]Testing and Documentation
Tests/LitheTests/AppSettingsTests.swift)docs/superpowers/specs/2026-08-17-cross-platform-logging-requirements.md)测试前后对比图

