-
Notifications
You must be signed in to change notification settings - Fork 71
Add log directory configuration for macOS #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a5dcbc6
feat(macOS): 添加日志目录设置
Wz58luck 0d2a260
Merge remote-tracking branch 'upstream/preview/0.3.0' into preview/0.3.0
Wz58luck 49827b7
fix(macOS): 补充日志目录设置中文翻译
Wz58luck 7321d53
style(macOS): 调整日志目录选择控件
Wz58luck 721736e
fix(macOS): 接入可配置日志输出目录
Wz58luck 03d87a1
fix(macOS): 修正日志文件描述符类型
Wz58luck 182b1f7
fix(macOS): 避免日志重定向测试阻塞
Wz58luck 7a7280d
fix(macOS): 隔离日志写入与测试进程
Wz58luck 215f463
ci(macOS): 放宽 Swift 测试超时时间
Wz58luck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import Foundation | ||
|
|
||
| protocol LogDirectoryProviding { | ||
| var defaultLogDirectory: URL { get } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
Sources/Lithe/Platform/MacOS/Logging/MacApplicationLogWriter.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import Darwin | ||
| import Foundation | ||
|
|
||
| final class MacApplicationLogWriter { | ||
| static let fileName = "lithe.log" | ||
|
|
||
| private let lock = NSLock() | ||
| private var directory: URL? | ||
|
|
||
| func redirect(to directory: URL) throws { | ||
| try FileManager.default.createDirectory( | ||
| at: directory, | ||
| withIntermediateDirectories: true | ||
| ) | ||
| let logURL = directory.appendingPathComponent(Self.fileName, isDirectory: false) | ||
| let descriptor: Int32 = logURL.withUnsafeFileSystemRepresentation { path in | ||
| guard let path else { return Int32(-1) } | ||
| return open(path, O_WRONLY | O_CREAT | O_APPEND, S_IRUSR | S_IWUSR) | ||
| } | ||
| guard descriptor >= 0 else { | ||
| throw POSIXError(POSIXErrorCode(rawValue: errno) ?? .EIO) | ||
| } | ||
| close(descriptor) | ||
|
|
||
| lock.lock() | ||
| self.directory = directory | ||
| lock.unlock() | ||
| } | ||
|
|
||
| func append(_ message: String) throws { | ||
| lock.lock() | ||
| defer { lock.unlock() } | ||
| guard let directory else { | ||
| throw CocoaError(.fileNoSuchFile) | ||
| } | ||
|
|
||
| let logURL = directory.appendingPathComponent(Self.fileName, isDirectory: false) | ||
| let descriptor: Int32 = logURL.withUnsafeFileSystemRepresentation { path in | ||
| guard let path else { return Int32(-1) } | ||
| return open(path, O_WRONLY | O_CREAT | O_APPEND, S_IRUSR | S_IWUSR) | ||
| } | ||
| guard descriptor >= 0 else { | ||
| throw POSIXError(POSIXErrorCode(rawValue: errno) ?? .EIO) | ||
| } | ||
| defer { close(descriptor) } | ||
|
|
||
| let data = Data(message.utf8) | ||
| let written = data.withUnsafeBytes { bytes in | ||
| Darwin.write(descriptor, bytes.baseAddress, bytes.count) | ||
| } | ||
| guard written == data.count else { | ||
| throw POSIXError(POSIXErrorCode(rawValue: errno) ?? .EIO) | ||
| } | ||
| } | ||
| } |
8 changes: 8 additions & 0 deletions
8
Sources/Lithe/Platform/MacOS/Logging/MacLogDirectoryProvider.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import Foundation | ||
|
|
||
| struct MacLogDirectoryProvider: LogDirectoryProviding { | ||
| var defaultLogDirectory: URL { | ||
| FileManager.default.urls(for: .libraryDirectory, in: .userDomainMask)[0] | ||
| .appendingPathComponent("Logs/Lithe", isDirectory: true) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.