おみくじ演出のタップスキップをiOSでも効くように修正#190
Merged
Merged
Conversation
装置canvasの Matter.Mouse が touchstart を preventDefault するため、 iOS Safari では canvas 上のタップで click が合成されず、ルートの @click="onTap" が発火しなかった(PCはマウスイベントなので動く)。 preventDefault はバブリングを止めないので、touchend でも onTap を 拾うようにする(finish() は二重呼び出しガード済みで click との 二重発火は無害。儀式中の touchend は従来どおり onTap 内で無視される)。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DwkB6Hj2JggoKcy7FoxNcU
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
kojira
pushed a commit
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原因
からくり装置のcanvasに
Matter.Mouse.create(canvas)がtouchstart/touchmoveリスナーを張りpreventDefault()を呼ぶため、iOS Safariでは touchstart が preventDefault されると click イベントが合成されない。canvasは画面全体を覆っているので、ルートの@click="onTap"がiPhoneのタップでは一切発火しなかった(PCはマウスイベント経由なので動く)。修正
preventDefaultはバブリングは止めないため、ルートで@touchend="onTap"も拾うようにする(1行)。finish()はphase === "done"ガード済みなので、click と touchend の二重発火は無害onTap内の phase 判定で無視されるyarn generate成功。実機確認はdevで(iPhoneで演出中にタップ→スキップ)。🤖 Generated with Claude Code
https://claude.ai/code/session_01DwkB6Hj2JggoKcy7FoxNcU
Generated by Claude Code