fix(codex): preserve Windows focus helper and clarify installation - #143
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 60.43% 60.44% +0.01%
==========================================
Files 60 60
Lines 6581 6583 +2
==========================================
+ Hits 3977 3979 +2
Misses 2290 2290
Partials 314 314 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
777genius
marked this pull request as ready for review
September 9, 2026 08:07
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex setup copied the notification executable but omitted the Windows GUI focus helper downloaded by install.sh. After bootstrap removed staging, toast clicks fell back to the console executable and could flash a console window. Preserve the exact amd64/arm64 focus helper names in the stable runtime copy.
README now separates Claude and Codex post-install/update steps, directs each product to its own manual fallback, and removes the incorrect once-only download claim. Codex hook registration is automatic; trust approval is still manual.
Validation: hosted isolated
go test ./internal/codexsetuppasses. Copy regression coverage verifies both Windows helper architectures and rejects an unsupported Linux helper. Independent read-only review found no actionable correctness defects. Final commit 446c0d6 passed all six Ubuntu/macOS/Windows jobs on Go 1.22/1.26, lint and Swift tests. Runs: Ubuntu 34326940595, macOS 34326940895, Windows 34326940558.A separate interactive curl-pipe E2E on the merged bootstrap and real v1.42.0 draft binary selected Codex twice, verified automatic hook registration and preservation of foreign hooks/settings, executed the exact registered Stop command, and captured one webhook. This proves the installer path, not Windows GUI focus or interactive Codex trust. The existing v1.42.0 draft predates this fix and must not be treated as qualified for publication without an updated candidate.
Related: #142, #141.
CI exposed an existing cross-package fixture collision: hook tests remove test-session files from the shared system temporary directory while the state workflow test uses that directory. State tests now own a t.TempDir per manager. Five repeated state suite runs passed under an unprivileged hosted sandbox user, retaining permission-denied coverage. Production state code is unchanged.
Expanded real E2E also passed menu choice 3 (both), twice: actual Claude CLI installed from a disposable local marketplace, Codex registered automatically, and the exact registered Stop command delivered one webhook. Only sandbox profiles and loopback-mirrored actual draft artifacts were used.