Skip to content

fix(codex): preserve Windows focus helper and clarify installation - #143

Merged
777genius merged 2 commits into
mainfrom
fix/codex-runtime-packaging
Sep 9, 2026
Merged

777genius merged 2 commits into
mainfrom
fix/codex-runtime-packaging

Conversation

@777genius

@777genius 777genius commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Codex setup copied the notification executable but omitted the Windows GUI focus helper downloaded by install.sh. After bootstrap removed staging, toast clicks fell back to the console executable and could flash a console window. Preserve the exact amd64/arm64 focus helper names in the stable runtime copy.

README now separates Claude and Codex post-install/update steps, directs each product to its own manual fallback, and removes the incorrect once-only download claim. Codex hook registration is automatic; trust approval is still manual.

Validation: hosted isolated go test ./internal/codexsetup passes. Copy regression coverage verifies both Windows helper architectures and rejects an unsupported Linux helper. Independent read-only review found no actionable correctness defects. Final commit 446c0d6 passed all six Ubuntu/macOS/Windows jobs on Go 1.22/1.26, lint and Swift tests. Runs: Ubuntu 34326940595, macOS 34326940895, Windows 34326940558.

A separate interactive curl-pipe E2E on the merged bootstrap and real v1.42.0 draft binary selected Codex twice, verified automatic hook registration and preservation of foreign hooks/settings, executed the exact registered Stop command, and captured one webhook. This proves the installer path, not Windows GUI focus or interactive Codex trust. The existing v1.42.0 draft predates this fix and must not be treated as qualified for publication without an updated candidate.

Related: #142, #141.

CI exposed an existing cross-package fixture collision: hook tests remove test-session files from the shared system temporary directory while the state workflow test uses that directory. State tests now own a t.TempDir per manager. Five repeated state suite runs passed under an unprivileged hosted sandbox user, retaining permission-denied coverage. Production state code is unchanged.

Expanded real E2E also passed menu choice 3 (both), twice: actual Claude CLI installed from a disposable local marketplace, Codex registered automatically, and the exact registered Stop command delivered one webhook. Only sandbox profiles and loopback-mirrored actual draft artifacts were used.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.44%. Comparing base (abd885f) to head (446c0d6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   60.43%   60.44%   +0.01%     
==========================================
  Files          60       60              
  Lines        6581     6583       +2     
==========================================
+ Hits         3977     3979       +2     
  Misses       2290     2290              
  Partials      314      314              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@777genius
777genius marked this pull request as ready for review September 9, 2026 08:07
@777genius
777genius merged commit 77db0ad into main Sep 9, 2026
11 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant