Conversation
Auto-default skips agent-notify MCP on unsupported OS or an old CLI and keeps hooks-only success. Explicit --agent-notify and a failed configure of a supported capability now return incomplete/nonzero without rolling back committed hooks. Co-authored-by: Илия <iliyazelenkog@gmail.com>
…etup Windows is a supported agent-notify configure OS after production toast delivery and navigation-none installer. Auto-default now calls configure instead of skipping as unsupported_platform; explicit --agent-notify no longer fails as an unsupported OS. Git Bash uname (mingw/msys/cygwin) is treated as Windows in bootstrap and /init. Co-authored-by: Илия <iliyazelenkog@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Илия <iliyazelenkog@gmail.com>
Windows identityMode stores 0666/0444 only, and clientsetup previously always returned ErrConflict from the non-unix reader. Add confined NT document reads and accept ledger-owned regular commands on Windows. Co-authored-by: Илия <iliyazelenkog@gmail.com>
Existing-installer configure pointed at bin/claude-notifications, which does not exist on Windows. Use the generated .bat alias and a small platform-named fixture so the e2e path runs under the 32 MiB cap. Co-authored-by: Илия <iliyazelenkog@gmail.com>
Co-authored-by: Илия <iliyazelenkog@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## cursor/uap-installer-windows-notify-6c84 #189 +/- ##
============================================================================
- Coverage 65.25% 65.06% -0.20%
============================================================================
Files 172 172
Lines 17287 17316 +29
============================================================================
- Hits 11281 11267 -14
- Misses 4383 4427 +44
+ Partials 1623 1622 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Илия <iliyazelenkog@gmail.com>
…tests notification_bootstrap_test.go only builds on linux/darwin, so comparing runtime.GOOS to windows is dead. Use agentNotifySetupSupported() instead. Co-authored-by: Илия <iliyazelenkog@gmail.com>
…ap-installer-windows-configure-6c84 Co-authored-by: Илия <iliyazelenkog@gmail.com>
…ap-installer-windows-configure-6c84 Co-authored-by: Илия <iliyazelenkog@gmail.com>
…ap-installer-windows-configure-6c84 Co-authored-by: Илия <iliyazelenkog@gmail.com>
…ap-installer-windows-configure-6c84 Co-authored-by: Илия <iliyazelenkog@gmail.com>
…ap-installer-windows-configure-6c84 Co-authored-by: Илия <iliyazelenkog@gmail.com>
Codex configure registered the skill, then enable revalidate Inspect compared the stored POSIX 0600 identity to the Windows fingerprint 0666 and returned registration_conflict. Keep the recorded 0600 contract; compare and CAS against IdentityMode so Inspect/no-op Apply succeed after projection. Co-authored-by: Илия <iliyazelenkog@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #187. After Windows production toast delivery and navigation-none installer, R0 auto/explicit
--agent-notifymust treat Windows as a supported MCP configure OS instead of skipping or erroring asunsupported_platform.This does not fold Windows into #185 (macOS-only capability gate on
#177) or into the Linux configure child of #186.What changed
agent_notify_platform_supported/agentNotifySetupSupported()accept Darwin or Windows (Git Bashmingw*/msys*/cygwin*)./initnow call configure on Windows (navigation=nonevia the existing default route).--agent-notifyon Windows is a real configure attempt, not an unsupported-OS failure.FlushFileBuffersdoes not support directory handles),NtCreateFileFILE_GENERIC_*rights (not unmappedGENERIC_WRITE),IdentityMode(0600)private policy, and portable locator filesystem.claude-notifications.batlauncher, not the Unixbin/claude-notificationsname that does not exist on Windows.TestSetupCodexE2EConfigureNotificationsnow stages a small platform-named writer instead of the 32 MiB Windows CLI, so the test can run on Windows runners.TestNotificationBootstrapWindowsGitBashUnamestubsunameasMINGW64_NTso Linux CI proves Git Bash platform detection.0600. Inspect/CAS compare that record to the host-retainedIdentityModeso Windows enable revalidate does not treat a just-projected skill asregistration_conflict.Tests
go test ./internal/agentnotify/clientsetup ./internal/agentnotify/setup ./cmd/claude-notifications -count=1TestSkillIdentitiesEqualHostModeand Windows-onlyTestWindowsSkillInspectAfterApplycover the fingerprint mismatch that failedTestSetupCodexE2EConfigureNotificationson GH Windows 1.26.