Skip to content

fix(release): pin Node 22.21.1 so 0.1.x can ship - #327

Open
777genius wants to merge 1 commit into
mainfrom
fix/release-pin-node-22.21.1
Open

777genius wants to merge 1 commit into
mainfrom
fix/release-pin-node-22.21.1

Conversation

@777genius

@777genius 777genius commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • agentplugins-v0.1.66 validate failed: release used floating node-version: 22 (v22.23.2) while authoring-native-qualification requires v22.21.1.
  • Pin the three release jobs to 22.21.1 to match required CI and the qualification contract.
  • Keep the unused agentplugins-v0.1.66 tag; cut 0.1.67 from this merge.

Test plan

  • GOWORK=off go test ./cmd/agentplugins -run TestStableReleaseRequiresVerifiedReproducibleBootstrapBeforeBuild
  • Merge, tag agentplugins-v0.1.67, dispatch Release Assets with publish_release=true

Summary by CodeRabbit

  • Chores

    • Pinned the release workflow to Node.js 22.21.1 for more consistent release execution.
  • Tests

    • Added validation to ensure all release stages use the exact Node.js version and reject unpinned versions.

Unpinned Node 22 floated to 22.23.2, so npm qualification refused the
release job while required CI still ran the exact 22.21.1 pin.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: bf1c5956-c697-4948-9a8a-f5f99c7f6177

📥 Commits

Reviewing files that changed from the base of the PR and between 148794a and a1cd349.

📒 Files selected for processing (2)
  • .github/workflows/agentplugins-release.yml
  • cli/plugin-kit-ai/cmd/agentplugins/release_workflow_test.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow now pins Node.js to 22.21.1 in three jobs. The release workflow test verifies all three pins and rejects unpinned node-version: 22 usage.

Changes

Release Node Version Pinning

Layer / File(s) Summary
Pin release Node.js and validate usage
.github/workflows/agentplugins-release.yml, cli/plugin-kit-ai/cmd/agentplugins/release_workflow_test.go
The validate, verified-draft, and promote-release jobs now use Node.js 22.21.1. The test requires three exact pins and rejects the unpinned major version.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains what changed and why, and it includes a focused test result. It does not use the required Verification and Release Impact sections or provide their required checklist items. Add the required Verification section with the repository checklist and mark the applicable checks. Add the Release Impact section and document public contract impact, documentation status, and release-sensitive path review. Keep the focuse…
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: pinning Node.js 22.21.1 in the release workflow so version 0.1.x can ship.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Add the required Verification section with the repository checklist and mark the applicable checks. Add the Release Impact section and document public contract impact, documentation status, and release-sensitive path review. Keep the focused test result and post-merge release steps under the appropriate sections.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version line
Three Node pins now align
The workflow hops with care
No floating numbers hide there
Tests guard the path everywhere

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.94%. Comparing base (148794a) to head (a1cd349).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   59.96%   59.94%   -0.02%     
==========================================
  Files        1321     1321              
  Lines       67544    67544              
==========================================
- Hits        40500    40492       -8     
- Misses      21460    21464       +4     
- Partials     5584     5588       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant