Skip to content

fix(release): pin Node 22.21.1 so 0.1.x can ship #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
777genius wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

fix(release): pin Node 22.21.1 so 0.1.x can ship #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/agentplugins-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ jobs:
run: go test ./cmd/agentplugins -run '^TestReleaseBuiltBinaryHasNoConformanceEnvironmentOverride$' -count=1
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
node-version: "22.21.1"
package-manager-cache: false
- name: Test npm bootstrap without install scripts
working-directory: npm/agentplugins
Expand Down Expand Up @@ -345,7 +345,7 @@ jobs:
ref: ${{ needs.validate.outputs.commit }}
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
node-version: "22.21.1"
package-manager-cache: false
- name: Verify live draft after successful platform proofs
env:
Expand Down Expand Up @@ -383,7 +383,7 @@ jobs:
ref: ${{ needs.validate.outputs.commit }}
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 22
node-version: "22.21.1"
package-manager-cache: false
- name: Reverify exact draft and promote only after all native proofs
env:
Expand Down
7 changes: 7 additions & 0 deletions cli/plugin-kit-ai/cmd/agentplugins/release_workflow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ func TestStableReleaseRequiresVerifiedReproducibleBootstrapBeforeBuild(t *testin
}
for _, required := range []string{
"go-version: 1.25.13",
"node-version: \"22.21.1\"",
"GOWORK: \"off\"",
"GOTOOLCHAIN: local",
"GOFLAGS: -buildvcs=false -p=1",
Expand All @@ -56,6 +57,12 @@ func TestStableReleaseRequiresVerifiedReproducibleBootstrapBeforeBuild(t *testin
t.Fatalf("agentplugins stable release lacks %q", required)
}
}
if strings.Count(workflow, "node-version: \"22.21.1\"") != 3 {
t.Fatal("agentplugins stable release must pin Node 22.21.1 on validate, verified-draft, and promote")
}
if strings.Contains(workflow, "node-version: 22\n") || strings.Contains(workflow, "node-version: 22\r") {
t.Fatal("agentplugins stable release must not use an unpinned Node 22")
}
negativeTestIndex := strings.Index(workflow, "TestReleaseBuiltBinaryHasNoConformanceEnvironmentOverride")
if negativeTestIndex < 0 || negativeTestIndex > buildIndex {
t.Fatal("negative release-binary conformance test must run in validate before release builds")
Expand Down
Loading